[GitHub] [flink] tillrohrmann commented on a change in pull request #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #7757: [FLINK-11630] Triggers the termination of all running Tasks when shutting down TaskExecutor
URL: https://github.com/apache/flink/pull/7757#discussion_r285996577
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java
 ##########
 @@ -335,9 +337,12 @@ private void handleStartTaskExecutorServicesException(Exception e) throws Except
 			resourceManagerConnection.close();
 		}
 
+		List<CompletableFuture<Void>> taskCompletionFutures = new ArrayList<>();
 		for (JobManagerConnection jobManagerConnection : jobManagerConnections.values()) {
 			try {
-				disassociateFromJobManager(jobManagerConnection, new FlinkException("The TaskExecutor is shutting down."));
+				FlinkException cause = new FlinkException("The TaskExecutor is shutting down.");
 
 Review comment:
   Please move outside of loop

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services