You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/08 18:00:52 UTC
[GitHub] [airflow] anitakar commented on a change in pull request #7570:
[AIRFLOW-6946] Switch to MySQL 5.7 in 2.0 as base
anitakar commented on a change in pull request #7570: [AIRFLOW-6946] Switch to MySQL 5.7 in 2.0 as base
URL: https://github.com/apache/airflow/pull/7570#discussion_r389391756
##########
File path: Dockerfile
##########
@@ -99,7 +99,7 @@ RUN KEY="A4A9406876FCBD3C456770C88C718D3B5072E1F5" \
&& gpgconf --kill all \
rm -rf "${GNUPGHOME}"; \
apt-key list > /dev/null \
- && echo "deb http://repo.mysql.com/apt/debian/ stretch mysql-5.6" | tee -a /etc/apt/sources.list.d/mysql.list \
+ && echo "deb http://repo.mysql.com/apt/debian/ stretch mysql-5.7" | tee -a /etc/apt/sources.list.d/mysql.list \
Review comment:
Instead of installing this debian package to be able to use libmysqlclient-dev, you could have also installed mariadb drivers (libmariadb-dev mariadb-client) and do not need installing any deb packages.
I have no preference here but I am just curious why have you decided to go with this solution?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services