You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/04/15 11:39:42 UTC
[GitHub] [airflow] potiuk commented on a diff in pull request #30175: Add provider for Apache Kafka
potiuk commented on code in PR #30175:
URL: https://github.com/apache/airflow/pull/30175#discussion_r1167480506
##########
docs/apache-airflow-providers-apache-kafka/connections/kafka.rst:
##########
@@ -0,0 +1,38 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+.. _howto/connection: kafka
+
+Apache Kafka Connection
+========================
+
+The Apache Kafka connection type configures a connection to Apache Kafka via the ``confluent-kafka`` Python package.
+
+Default Connection IDs
+----------------------
+
+Kafka hooks and operators use ``kafka_default`` by default.
Review Comment:
Good one.That reminds me that is about the last thing where we will have "core" referring to particular "providers" (once we move executors to providers). One more last step to truly decouple providers from the core.
And yeah. I think we should have a default connection here.
##########
docs/apache-airflow-providers-apache-kafka/connections/kafka.rst:
##########
@@ -0,0 +1,38 @@
+ .. Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ .. http://www.apache.org/licenses/LICENSE-2.0
+
+ .. Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+
+.. _howto/connection: kafka
+
+Apache Kafka Connection
+========================
+
+The Apache Kafka connection type configures a connection to Apache Kafka via the ``confluent-kafka`` Python package.
+
+Default Connection IDs
+----------------------
+
+Kafka hooks and operators use ``kafka_default`` by default.
Review Comment:
Good one. That reminds me that is about the last thing where we will have "core" referring to particular "providers" (once we move executors to providers). One more last step to truly decouple providers from the core.
And yeah. I think we should have a default connection here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org