[jira] [Created] (HADOOP-15962) FileUtils Small Buffer Size

["BELUGA BEHR (JIRA)" <ji...@apache.org>]

BELUGA BEHR created HADOOP-15962:
------------------------------------

             Summary: FileUtils Small Buffer Size
                 Key: HADOOP-15962
                 URL: https://issues.apache.org/jira/browse/HADOOP-15962
             Project: Hadoop Common
          Issue Type: Improvement
          Components: common
    Affects Versions: 3.3.0
            Reporter: BELUGA BEHR


Note sure if this code is even being used, but it implements a copy routing utilizing a 2K buffer.  Modern JVM uses 8K, but 4K should be minimum.  Also, there are libraries for this stuff.

{code:java|title=FileUtil.java}
    int count;
    byte data[] = new byte[2048];
    try (BufferedOutputStream outputStream = new BufferedOutputStream(
        new FileOutputStream(outputFile));) {

      while ((count = tis.read(data)) != -1) {
        outputStream.write(data, 0, count);
      }

      outputStream.flush();
    }
{code}

I also fixed a couple of check-style warnings.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org