You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Josh Tynjala <jo...@gmail.com> on 2016/10/29 20:11:29 UTC
Re: [FlexJS] Optimizing the maven build ... success ...
Nice. Good work, Chris!
- Josh
On Oct 29, 2016 12:37 PM, "Christofer Dutz" <ch...@c-ware.de>
wrote:
> Hi,
>
> the last few days I invested quite some time in optimizing the compilation
> for Maven.
>
> So far the compile-times for the entire framework part including all
> examples has dropped from 17:38 to 3:10 minutes.
> And the build time of the Charts examle has dropped from 46,7 to 6,5
> seconds.
>
> As the change will not have any effect on non JS compilation, the speedup
> is demonstrated in the example builds. So it seems that my changes reduced
> the build time by more than 90% ... I could say that I’m quite sattisfied
> with that ;-)
>
> I achieved this by introducing a white-list of which closure files to use
> (I inherited that from the frameworks download.xml). Additionally I not
> only dump the remaining files to disk, I also directly pass the content
> into the compiler.
> I did notice, that I will probably do some further cleaning up in the
> MXMLFlexJSPublisher and associated classes.
>
> My changes are in the feature-autobuild/closure-classpath-sources branch.
>
> Chris
>
>
>
>
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Just confirm that MDLExample now builds in 8 secs first time and 3'6
second. Awesome! :)
2016-10-30 17:16 GMT+01:00 Carlos Rovira <ca...@codeoscopic.com>:
> Ok Chris, I was just figuring it, thanks to confirm.
> Just notice that maybe It would be ok to rebase it on top of develop to
> get latest changes? (just figuring)
> thanks!
>
> 2016-10-30 17:12 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
>
>> Hi Carlos,
>>
>> right now you can try it by switching the branch. I didn’t want to merge
>> it back to develop untill I get some confirmation from the Ant fraction
>> that it doesn’t break anything on their side.
>> One thing I noticed at the moment is that I can’t seem to be able to run
>> the release compilation. It always produces only the debug output. Will
>> have to figure that out next.
>>
>> Chris
>>
>>
>> Am 30.10.16, 16:57 schrieb "carlos.rovira@gmail.com im Auftrag von
>> Carlos Rovira" <carlos.rovira@gmail.com im Auftrag von
>> carlos.rovira@codeoscopic.com>:
>>
>> O_o
>> Awesome Chris!
>> Can't wait to try it! :)
>>
>> 2016-10-29 22:11 GMT+02:00 Josh Tynjala <jo...@gmail.com>:
>>
>> > Nice. Good work, Chris!
>> >
>> > - Josh
>> >
>> > On Oct 29, 2016 12:37 PM, "Christofer Dutz" <
>> christofer.dutz@c-ware.de>
>> > wrote:
>> >
>> > > Hi,
>> > >
>> > > the last few days I invested quite some time in optimizing the
>> > compilation
>> > > for Maven.
>> > >
>> > > So far the compile-times for the entire framework part including
>> all
>> > > examples has dropped from 17:38 to 3:10 minutes.
>> > > And the build time of the Charts examle has dropped from 46,7 to
>> 6,5
>> > > seconds.
>> > >
>> > > As the change will not have any effect on non JS compilation, the
>> speedup
>> > > is demonstrated in the example builds. So it seems that my changes
>> > reduced
>> > > the build time by more than 90% ... I could say that I’m quite
>> sattisfied
>> > > with that ;-)
>> > >
>> > > I achieved this by introducing a white-list of which closure
>> files to use
>> > > (I inherited that from the frameworks download.xml). Additionally
>> I not
>> > > only dump the remaining files to disk, I also directly pass the
>> content
>> > > into the compiler.
>> > > I did notice, that I will probably do some further cleaning up in
>> the
>> > > MXMLFlexJSPublisher and associated classes.
>> > >
>> > > My changes are in the feature-autobuild/closure-classpath-sources
>> > branch.
>> > >
>> > > Chris
>> > >
>> > >
>> > >
>> > >
>> >
>>
>>
>>
>> --
>>
>> Carlos Rovira
>> Director General
>> M: +34 607 22 60 05
>> http://www.codeoscopic.com
>> http://www.avant2.es
>>
>>
>> Este mensaje se dirige exclusivamente a su destinatario y puede
>> contener
>> información privilegiada o confidencial. Si ha recibido este mensaje
>> por
>> error, le rogamos que nos lo comunique inmediatamente por esta misma
>> vía y
>> proceda a su destrucción.
>>
>> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>> comunicamos
>> que sus datos forman parte de un fichero cuyo responsable es
>> CODEOSCOPIC
>> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
>> servicio o información solicitados, teniendo usted derecho de acceso,
>> rectificación, cancelación y oposición de sus datos dirigiéndose a
>> nuestras
>> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
>> documentación
>> necesaria.
>>
>>
>>
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
>
> Este mensaje se dirige exclusivamente a su destinatario y puede contener
> información privilegiada o confidencial. Si ha recibido este mensaje por
> error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos que sus datos forman parte de un fichero cuyo responsable es
> CODEOSCOPIC S.A. La finalidad de dicho tratamiento es facilitar la
> prestación del servicio o información solicitados, teniendo usted derecho
> de acceso, rectificación, cancelación y oposición de sus datos dirigiéndose
> a nuestras oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
> documentación necesaria.
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Ok Chris, I was just figuring it, thanks to confirm.
Just notice that maybe It would be ok to rebase it on top of develop to get
latest changes? (just figuring)
thanks!
2016-10-30 17:12 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
> Hi Carlos,
>
> right now you can try it by switching the branch. I didn’t want to merge
> it back to develop untill I get some confirmation from the Ant fraction
> that it doesn’t break anything on their side.
> One thing I noticed at the moment is that I can’t seem to be able to run
> the release compilation. It always produces only the debug output. Will
> have to figure that out next.
>
> Chris
>
>
> Am 30.10.16, 16:57 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos
> Rovira" <carlos.rovira@gmail.com im Auftrag von
> carlos.rovira@codeoscopic.com>:
>
> O_o
> Awesome Chris!
> Can't wait to try it! :)
>
> 2016-10-29 22:11 GMT+02:00 Josh Tynjala <jo...@gmail.com>:
>
> > Nice. Good work, Chris!
> >
> > - Josh
> >
> > On Oct 29, 2016 12:37 PM, "Christofer Dutz" <
> christofer.dutz@c-ware.de>
> > wrote:
> >
> > > Hi,
> > >
> > > the last few days I invested quite some time in optimizing the
> > compilation
> > > for Maven.
> > >
> > > So far the compile-times for the entire framework part including
> all
> > > examples has dropped from 17:38 to 3:10 minutes.
> > > And the build time of the Charts examle has dropped from 46,7 to
> 6,5
> > > seconds.
> > >
> > > As the change will not have any effect on non JS compilation, the
> speedup
> > > is demonstrated in the example builds. So it seems that my changes
> > reduced
> > > the build time by more than 90% ... I could say that I’m quite
> sattisfied
> > > with that ;-)
> > >
> > > I achieved this by introducing a white-list of which closure files
> to use
> > > (I inherited that from the frameworks download.xml). Additionally
> I not
> > > only dump the remaining files to disk, I also directly pass the
> content
> > > into the compiler.
> > > I did notice, that I will probably do some further cleaning up in
> the
> > > MXMLFlexJSPublisher and associated classes.
> > >
> > > My changes are in the feature-autobuild/closure-classpath-sources
> > branch.
> > >
> > > Chris
> > >
> > >
> > >
> > >
> >
>
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
>
> Este mensaje se dirige exclusivamente a su destinatario y puede
> contener
> información privilegiada o confidencial. Si ha recibido este mensaje
> por
> error, le rogamos que nos lo comunique inmediatamente por esta misma
> vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> que sus datos forman parte de un fichero cuyo responsable es
> CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.
>
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Alex Harui <ah...@adobe.com>.
All good from the Ant side.
Thanks,
-Alex
On 11/4/16, 2:34 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Ok I did the merge and I hopefully fixed an issue Alex mentioned with
>„closure/closure“ directory structure.
>@Carlos Rovira ... please give it another try (as soon as jenkins is
>finished with it)
>@Alex Harui ... please give the Ant build another try
>
>If the ant issue is fixed, I think I could merge back my changes.
>
>Chris
>
>Am 04.11.16, 09:58 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos
>Rovira" <carlos.rovira@gmail.com im Auftrag von
>carlos.rovira@codeoscopic.com>:
>
> Ok Chris,
>
> currently the branch is no longer usable due to some changes by Alex
> yesterday
>
> 2c8becbcb22052105d8a614196f1d36db6b909ec
>
> if you try to rebase on top of develop it throws 69 conflicts
>
> Hope you could get it work again since is hard to get back to 44secs
>vs
> 4secs buildings ;)
>
>
>
> 2016-11-04 7:51 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
>
> > Hi Carlos,
> >
> > I didn’t want to merge it back without getting confirmation, that it
> > doesn’t break things for all non-maven builds. I think there still
>is an
> > issue, which I will have to figgure out as soon as I can find the
>time
> > (Unfortunatlely I currently have a paid-project which I actually
>have to
> > work for ... not like the last 2 years ;-) )
> > I’ll try to sort out the problem as soon as possible and as soon as
>I get
> > the ok from one of the Ants, I’ll gladly merge back my changes.
> >
> > Chris
> >
> > Am 04.11.16, 00:19 schrieb "carlos.rovira@gmail.com im Auftrag von
>Carlos
> > Rovira" <carlos.rovira@gmail.com im Auftrag von
> > carlos.rovira@codeoscopic.com>:
> >
> > Hi Chris,
> >
> > I'm using the "closure-classpath-sources" branch, taking into
>account
> > the
> > fast it makes me build, I was wondering what's the problem to
>merge it
> > to
> > develop. Hope it was a matter of tiny things and could be
>integrated
> > soon.
> >
> > Thanks
> >
> > Carlos
> >
> > 2016-10-31 16:40 GMT+01:00 Alex Harui <ah...@adobe.com>:
> >
> > >
> > >
> > > On 10/31/16, 8:36 AM, "Christofer Dutz"
><ch...@c-ware.de>
> > wrote:
> > >
> > > >Hi Alex,
> > > >
> > > >Well I had another look at the original code. Seems I have to
> > include
> > > >that commented out line again as this copies the content of
> > closure-lib
> > > >into the debug-js directory. This should only be executed in
>Ant
> > builds.
> > >
> > > I would think the copy code would be used for all non-Maven
>builds,
> > not
> > > just Ant. Command-line, Flash Builder and other IDEs as well.
> > >
> > > -Alex
> > >
> > >
> >
> >
> > --
> >
> > Carlos Rovira
> > Director General
> > M: +34 607 22 60 05
> > http://www.codeoscopic.com
> > http://www.avant2.es
> >
> >
> > Este mensaje se dirige exclusivamente a su destinatario y puede
> > contener
> > información privilegiada o confidencial. Si ha recibido este
>mensaje
> > por
> > error, le rogamos que nos lo comunique inmediatamente por esta
>misma
> > vía y
> > proceda a su destrucción.
> >
> > De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> > comunicamos
> > que sus datos forman parte de un fichero cuyo responsable es
> > CODEOSCOPIC
> > S.A. La finalidad de dicho tratamiento es facilitar la
>prestación del
> > servicio o información solicitados, teniendo usted derecho de
>acceso,
> > rectificación, cancelación y oposición de sus datos
>dirigiéndose a
> > nuestras
> > oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
>documentación
> > necesaria.
> >
> >
> >
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
>
> Este mensaje se dirige exclusivamente a su destinatario y puede
>contener
> información privilegiada o confidencial. Si ha recibido este mensaje
>por
> error, le rogamos que nos lo comunique inmediatamente por esta misma
>vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
>comunicamos
> que sus datos forman parte de un fichero cuyo responsable es
>CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a
>nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
>documentación
> necesaria.
>
>
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi Chris,
just tried and working again. Thanks for you blazing fast action! :)
sweet 4sec builds :)
2016-11-04 10:34 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
> Ok I did the merge and I hopefully fixed an issue Alex mentioned with
> „closure/closure“ directory structure.
> @Carlos Rovira ... please give it another try (as soon as jenkins is
> finished with it)
> @Alex Harui ... please give the Ant build another try
>
> If the ant issue is fixed, I think I could merge back my changes.
>
> Chris
>
> Am 04.11.16, 09:58 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos
> Rovira" <carlos.rovira@gmail.com im Auftrag von
> carlos.rovira@codeoscopic.com>:
>
> Ok Chris,
>
> currently the branch is no longer usable due to some changes by Alex
> yesterday
>
> 2c8becbcb22052105d8a614196f1d36db6b909ec
>
> if you try to rebase on top of develop it throws 69 conflicts
>
> Hope you could get it work again since is hard to get back to 44secs vs
> 4secs buildings ;)
>
>
>
> 2016-11-04 7:51 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
>
> > Hi Carlos,
> >
> > I didn’t want to merge it back without getting confirmation, that it
> > doesn’t break things for all non-maven builds. I think there still
> is an
> > issue, which I will have to figgure out as soon as I can find the
> time
> > (Unfortunatlely I currently have a paid-project which I actually
> have to
> > work for ... not like the last 2 years ;-) )
> > I’ll try to sort out the problem as soon as possible and as soon as
> I get
> > the ok from one of the Ants, I’ll gladly merge back my changes.
> >
> > Chris
> >
> > Am 04.11.16, 00:19 schrieb "carlos.rovira@gmail.com im Auftrag von
> Carlos
> > Rovira" <carlos.rovira@gmail.com im Auftrag von
> > carlos.rovira@codeoscopic.com>:
> >
> > Hi Chris,
> >
> > I'm using the "closure-classpath-sources" branch, taking into
> account
> > the
> > fast it makes me build, I was wondering what's the problem to
> merge it
> > to
> > develop. Hope it was a matter of tiny things and could be
> integrated
> > soon.
> >
> > Thanks
> >
> > Carlos
> >
> > 2016-10-31 16:40 GMT+01:00 Alex Harui <ah...@adobe.com>:
> >
> > >
> > >
> > > On 10/31/16, 8:36 AM, "Christofer Dutz" <
> christofer.dutz@c-ware.de>
> > wrote:
> > >
> > > >Hi Alex,
> > > >
> > > >Well I had another look at the original code. Seems I have to
> > include
> > > >that commented out line again as this copies the content of
> > closure-lib
> > > >into the debug-js directory. This should only be executed in
> Ant
> > builds.
> > >
> > > I would think the copy code would be used for all non-Maven
> builds,
> > not
> > > just Ant. Command-line, Flash Builder and other IDEs as well.
> > >
> > > -Alex
> > >
> > >
> >
> >
> > --
> >
> > Carlos Rovira
> > Director General
> > M: +34 607 22 60 05
> > http://www.codeoscopic.com
> > http://www.avant2.es
> >
> >
> > Este mensaje se dirige exclusivamente a su destinatario y puede
> > contener
> > información privilegiada o confidencial. Si ha recibido este
> mensaje
> > por
> > error, le rogamos que nos lo comunique inmediatamente por esta
> misma
> > vía y
> > proceda a su destrucción.
> >
> > De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> > comunicamos
> > que sus datos forman parte de un fichero cuyo responsable es
> > CODEOSCOPIC
> > S.A. La finalidad de dicho tratamiento es facilitar la
> prestación del
> > servicio o información solicitados, teniendo usted derecho de
> acceso,
> > rectificación, cancelación y oposición de sus datos dirigiéndose
> a
> > nuestras
> > oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la
> documentación
> > necesaria.
> >
> >
> >
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
>
> Este mensaje se dirige exclusivamente a su destinatario y puede
> contener
> información privilegiada o confidencial. Si ha recibido este mensaje
> por
> error, le rogamos que nos lo comunique inmediatamente por esta misma
> vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> que sus datos forman parte de un fichero cuyo responsable es
> CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.
>
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Ok I did the merge and I hopefully fixed an issue Alex mentioned with „closure/closure“ directory structure.
@Carlos Rovira ... please give it another try (as soon as jenkins is finished with it)
@Alex Harui ... please give the Ant build another try
If the ant issue is fixed, I think I could merge back my changes.
Chris
Am 04.11.16, 09:58 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos Rovira" <carlos.rovira@gmail.com im Auftrag von carlos.rovira@codeoscopic.com>:
Ok Chris,
currently the branch is no longer usable due to some changes by Alex
yesterday
2c8becbcb22052105d8a614196f1d36db6b909ec
if you try to rebase on top of develop it throws 69 conflicts
Hope you could get it work again since is hard to get back to 44secs vs
4secs buildings ;)
2016-11-04 7:51 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
> Hi Carlos,
>
> I didn’t want to merge it back without getting confirmation, that it
> doesn’t break things for all non-maven builds. I think there still is an
> issue, which I will have to figgure out as soon as I can find the time
> (Unfortunatlely I currently have a paid-project which I actually have to
> work for ... not like the last 2 years ;-) )
> I’ll try to sort out the problem as soon as possible and as soon as I get
> the ok from one of the Ants, I’ll gladly merge back my changes.
>
> Chris
>
> Am 04.11.16, 00:19 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos
> Rovira" <carlos.rovira@gmail.com im Auftrag von
> carlos.rovira@codeoscopic.com>:
>
> Hi Chris,
>
> I'm using the "closure-classpath-sources" branch, taking into account
> the
> fast it makes me build, I was wondering what's the problem to merge it
> to
> develop. Hope it was a matter of tiny things and could be integrated
> soon.
>
> Thanks
>
> Carlos
>
> 2016-10-31 16:40 GMT+01:00 Alex Harui <ah...@adobe.com>:
>
> >
> >
> > On 10/31/16, 8:36 AM, "Christofer Dutz" <ch...@c-ware.de>
> wrote:
> >
> > >Hi Alex,
> > >
> > >Well I had another look at the original code. Seems I have to
> include
> > >that commented out line again as this copies the content of
> closure-lib
> > >into the debug-js directory. This should only be executed in Ant
> builds.
> >
> > I would think the copy code would be used for all non-Maven builds,
> not
> > just Ant. Command-line, Flash Builder and other IDEs as well.
> >
> > -Alex
> >
> >
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
>
> Este mensaje se dirige exclusivamente a su destinatario y puede
> contener
> información privilegiada o confidencial. Si ha recibido este mensaje
> por
> error, le rogamos que nos lo comunique inmediatamente por esta misma
> vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> que sus datos forman parte de un fichero cuyo responsable es
> CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.
>
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Ok Chris,
currently the branch is no longer usable due to some changes by Alex
yesterday
2c8becbcb22052105d8a614196f1d36db6b909ec
if you try to rebase on top of develop it throws 69 conflicts
Hope you could get it work again since is hard to get back to 44secs vs
4secs buildings ;)
2016-11-04 7:51 GMT+01:00 Christofer Dutz <ch...@c-ware.de>:
> Hi Carlos,
>
> I didn’t want to merge it back without getting confirmation, that it
> doesn’t break things for all non-maven builds. I think there still is an
> issue, which I will have to figgure out as soon as I can find the time
> (Unfortunatlely I currently have a paid-project which I actually have to
> work for ... not like the last 2 years ;-) )
> I’ll try to sort out the problem as soon as possible and as soon as I get
> the ok from one of the Ants, I’ll gladly merge back my changes.
>
> Chris
>
> Am 04.11.16, 00:19 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos
> Rovira" <carlos.rovira@gmail.com im Auftrag von
> carlos.rovira@codeoscopic.com>:
>
> Hi Chris,
>
> I'm using the "closure-classpath-sources" branch, taking into account
> the
> fast it makes me build, I was wondering what's the problem to merge it
> to
> develop. Hope it was a matter of tiny things and could be integrated
> soon.
>
> Thanks
>
> Carlos
>
> 2016-10-31 16:40 GMT+01:00 Alex Harui <ah...@adobe.com>:
>
> >
> >
> > On 10/31/16, 8:36 AM, "Christofer Dutz" <ch...@c-ware.de>
> wrote:
> >
> > >Hi Alex,
> > >
> > >Well I had another look at the original code. Seems I have to
> include
> > >that commented out line again as this copies the content of
> closure-lib
> > >into the debug-js directory. This should only be executed in Ant
> builds.
> >
> > I would think the copy code would be used for all non-Maven builds,
> not
> > just Ant. Command-line, Flash Builder and other IDEs as well.
> >
> > -Alex
> >
> >
>
>
> --
>
> Carlos Rovira
> Director General
> M: +34 607 22 60 05
> http://www.codeoscopic.com
> http://www.avant2.es
>
>
> Este mensaje se dirige exclusivamente a su destinatario y puede
> contener
> información privilegiada o confidencial. Si ha recibido este mensaje
> por
> error, le rogamos que nos lo comunique inmediatamente por esta misma
> vía y
> proceda a su destrucción.
>
> De la vigente Ley Orgánica de Protección de Datos (15/1999), le
> comunicamos
> que sus datos forman parte de un fichero cuyo responsable es
> CODEOSCOPIC
> S.A. La finalidad de dicho tratamiento es facilitar la prestación del
> servicio o información solicitados, teniendo usted derecho de acceso,
> rectificación, cancelación y oposición de sus datos dirigiéndose a
> nuestras
> oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
> necesaria.
>
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Carlos,
I didn’t want to merge it back without getting confirmation, that it doesn’t break things for all non-maven builds. I think there still is an issue, which I will have to figgure out as soon as I can find the time (Unfortunatlely I currently have a paid-project which I actually have to work for ... not like the last 2 years ;-) )
I’ll try to sort out the problem as soon as possible and as soon as I get the ok from one of the Ants, I’ll gladly merge back my changes.
Chris
Am 04.11.16, 00:19 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos Rovira" <carlos.rovira@gmail.com im Auftrag von carlos.rovira@codeoscopic.com>:
Hi Chris,
I'm using the "closure-classpath-sources" branch, taking into account the
fast it makes me build, I was wondering what's the problem to merge it to
develop. Hope it was a matter of tiny things and could be integrated soon.
Thanks
Carlos
2016-10-31 16:40 GMT+01:00 Alex Harui <ah...@adobe.com>:
>
>
> On 10/31/16, 8:36 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>
> >Hi Alex,
> >
> >Well I had another look at the original code. Seems I have to include
> >that commented out line again as this copies the content of closure-lib
> >into the debug-js directory. This should only be executed in Ant builds.
>
> I would think the copy code would be used for all non-Maven builds, not
> just Ant. Command-line, Flash Builder and other IDEs as well.
>
> -Alex
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Carlos Rovira <ca...@codeoscopic.com>.
Hi Chris,
I'm using the "closure-classpath-sources" branch, taking into account the
fast it makes me build, I was wondering what's the problem to merge it to
develop. Hope it was a matter of tiny things and could be integrated soon.
Thanks
Carlos
2016-10-31 16:40 GMT+01:00 Alex Harui <ah...@adobe.com>:
>
>
> On 10/31/16, 8:36 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>
> >Hi Alex,
> >
> >Well I had another look at the original code. Seems I have to include
> >that commented out line again as this copies the content of closure-lib
> >into the debug-js directory. This should only be executed in Ant builds.
>
> I would think the copy code would be used for all non-Maven builds, not
> just Ant. Command-line, Flash Builder and other IDEs as well.
>
> -Alex
>
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Alex Harui <ah...@adobe.com>.
On 10/31/16, 8:36 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Alex,
>
>Well I had another look at the original code. Seems I have to include
>that commented out line again as this copies the content of closure-lib
>into the debug-js directory. This should only be executed in Ant builds.
I would think the copy code would be used for all non-Maven builds, not
just Ant. Command-line, Flash Builder and other IDEs as well.
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,
Well I had another look at the original code. Seems I have to include that commented out line again as this copies the content of closure-lib into the debug-js directory. This should only be executed in Ant builds.
I’ll look into this ... currently I’m finishing up the distribution (generating the missing dummy manifest-only jar files in the lib dir)
Chris
Am 31.10.16, 16:08 schrieb "Alex Harui" <ah...@adobe.com>:
On 10/31/16, 8:01 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Alex,
>
>thanks for your responses. Well I made it check the closureLib as I
>wanted to allow users to specify that if they wanted to monkey-patch
>stuff.
In looking into the Ant scripts, closure-lib is being set. Did setting
closureLib result in files being copied for you?
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Alex Harui <ah...@adobe.com>.
On 10/31/16, 8:01 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Alex,
>
>thanks for your responses. Well I made it check the closureLib as I
>wanted to allow users to specify that if they wanted to monkey-patch
>stuff.
In looking into the Ant scripts, closure-lib is being set. Did setting
closureLib result in files being copied for you?
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Alex,
thanks for your responses. Well I made it check the closureLib as I wanted to allow users to specify that if they wanted to monkey-patch stuff.
Well for now I removed the VF2JS stuff in my branch. I think I remember us discussing that and that consensus was to remove the code.
At least with my last commits I managed the release build to work and I no longer dump the closure stuff to release.
Chris
Am 31.10.16, 15:46 schrieb "Alex Harui" <ah...@adobe.com>:
On 10/31/16, 1:14 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>My optimization should have an effect if the closureLib is NOT explicitly
>set and the file „goog/deps.js“ is found on the compilers classpath. This
>is probably only the case for Maven builds.
I think closureLib is sometimes set for me. Any reason not to just rely
on whether you find deps.js on the class path?
>
>Currently the release build doesn’t kick in at all, even for a Maven
>build. I am hoping to fix this today after I understood the class a
>little better.
I assume you know that the release build is contingent on the -debug flag.
Is there more to it than that?
>
>Currently it seems as if for a debug build closure is only needed for
>dumping the dependency js files to the debug directory - is that correct?
The Closure Compiler? I wasn't aware it was used at all for debug builds,
but I don't know this code in detail.
Closure Library is needed to run the goog.provide and goog.require and
goog.events code.
>The actual closure compiler kicks in with compiling only for the release
>build – is that correct?
That's my understanding.
>If this is correct, why is the closure code dumped to the debug and the
>release directory?
Don't know. I don't see the closure library code in the bin/js-release.
Does the Closure Compiler compile in-place and remove files?
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Alex Harui <ah...@adobe.com>.
On 10/31/16, 1:14 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>My optimization should have an effect if the closureLib is NOT explicitly
>set and the file „goog/deps.js“ is found on the compilers classpath. This
>is probably only the case for Maven builds.
I think closureLib is sometimes set for me. Any reason not to just rely
on whether you find deps.js on the class path?
>
>Currently the release build doesn’t kick in at all, even for a Maven
>build. I am hoping to fix this today after I understood the class a
>little better.
I assume you know that the release build is contingent on the -debug flag.
Is there more to it than that?
>
>Currently it seems as if for a debug build closure is only needed for
>dumping the dependency js files to the debug directory - is that correct?
The Closure Compiler? I wasn't aware it was used at all for debug builds,
but I don't know this code in detail.
Closure Library is needed to run the goog.provide and goog.require and
goog.events code.
>The actual closure compiler kicks in with compiling only for the release
>build – is that correct?
That's my understanding.
>If this is correct, why is the closure code dumped to the debug and the
>release directory?
Don't know. I don't see the closure library code in the bin/js-release.
Does the Closure Compiler compile in-place and remove files?
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Christofer Dutz <ch...@c-ware.de>.
My optimization should have an effect if the closureLib is NOT explicitly set and the file „goog/deps.js“ is found on the compilers classpath. This is probably only the case for Maven builds.
I am currently working on cleaning up the MXMLFlexJSPublisher as I noticed a lot of things were done quite complicated and the code was hard to understand. And I also noticed quite a lot of dead code, which I am currently removing.
Currently the release build doesn’t kick in at all, even for a Maven build. I am hoping to fix this today after I understood the class a little better.
Currently it seems as if for a debug build closure is only needed for dumping the dependency js files to the debug directory - is that correct?
The actual closure compiler kicks in with compiling only for the release build – is that correct?
If this is correct, why is the closure code dumped to the debug and the release directory?
Chris
Am 31.10.16, 06:09 schrieb "Alex Harui" <ah...@adobe.com>:
On 10/30/16, 9:12 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Carlos,
>
>right now you can try it by switching the branch. I didn’t want to merge
>it back to develop untill I get some confirmation from the Ant fraction
>that it doesn’t break anything on their side.
I built the branch. The build passed. Then I tried to compile the
DataBindingExample, and the compiler didn't seem to copy the subset of
Google Closure Library files. I'm not clear on the goal: did you intend
to replace copying the files for non-Maven users as well as Maven users?
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Alex Harui <ah...@adobe.com>.
On 10/30/16, 9:12 AM, "Christofer Dutz" <ch...@c-ware.de> wrote:
>Hi Carlos,
>
>right now you can try it by switching the branch. I didn’t want to merge
>it back to develop untill I get some confirmation from the Ant fraction
>that it doesn’t break anything on their side.
I built the branch. The build passed. Then I tried to compile the
DataBindingExample, and the compiler didn't seem to copy the subset of
Google Closure Library files. I'm not clear on the goal: did you intend
to replace copying the files for non-Maven users as well as Maven users?
-Alex
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Christofer Dutz <ch...@c-ware.de>.
Hi Carlos,
right now you can try it by switching the branch. I didn’t want to merge it back to develop untill I get some confirmation from the Ant fraction that it doesn’t break anything on their side.
One thing I noticed at the moment is that I can’t seem to be able to run the release compilation. It always produces only the debug output. Will have to figure that out next.
Chris
Am 30.10.16, 16:57 schrieb "carlos.rovira@gmail.com im Auftrag von Carlos Rovira" <carlos.rovira@gmail.com im Auftrag von carlos.rovira@codeoscopic.com>:
O_o
Awesome Chris!
Can't wait to try it! :)
2016-10-29 22:11 GMT+02:00 Josh Tynjala <jo...@gmail.com>:
> Nice. Good work, Chris!
>
> - Josh
>
> On Oct 29, 2016 12:37 PM, "Christofer Dutz" <ch...@c-ware.de>
> wrote:
>
> > Hi,
> >
> > the last few days I invested quite some time in optimizing the
> compilation
> > for Maven.
> >
> > So far the compile-times for the entire framework part including all
> > examples has dropped from 17:38 to 3:10 minutes.
> > And the build time of the Charts examle has dropped from 46,7 to 6,5
> > seconds.
> >
> > As the change will not have any effect on non JS compilation, the speedup
> > is demonstrated in the example builds. So it seems that my changes
> reduced
> > the build time by more than 90% ... I could say that I’m quite sattisfied
> > with that ;-)
> >
> > I achieved this by introducing a white-list of which closure files to use
> > (I inherited that from the frameworks download.xml). Additionally I not
> > only dump the remaining files to disk, I also directly pass the content
> > into the compiler.
> > I did notice, that I will probably do some further cleaning up in the
> > MXMLFlexJSPublisher and associated classes.
> >
> > My changes are in the feature-autobuild/closure-classpath-sources
> branch.
> >
> > Chris
> >
> >
> >
> >
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.
Re: [FlexJS] Optimizing the maven build ... success ...
Posted by Carlos Rovira <ca...@codeoscopic.com>.
O_o
Awesome Chris!
Can't wait to try it! :)
2016-10-29 22:11 GMT+02:00 Josh Tynjala <jo...@gmail.com>:
> Nice. Good work, Chris!
>
> - Josh
>
> On Oct 29, 2016 12:37 PM, "Christofer Dutz" <ch...@c-ware.de>
> wrote:
>
> > Hi,
> >
> > the last few days I invested quite some time in optimizing the
> compilation
> > for Maven.
> >
> > So far the compile-times for the entire framework part including all
> > examples has dropped from 17:38 to 3:10 minutes.
> > And the build time of the Charts examle has dropped from 46,7 to 6,5
> > seconds.
> >
> > As the change will not have any effect on non JS compilation, the speedup
> > is demonstrated in the example builds. So it seems that my changes
> reduced
> > the build time by more than 90% ... I could say that I’m quite sattisfied
> > with that ;-)
> >
> > I achieved this by introducing a white-list of which closure files to use
> > (I inherited that from the frameworks download.xml). Additionally I not
> > only dump the remaining files to disk, I also directly pass the content
> > into the compiler.
> > I did notice, that I will probably do some further cleaning up in the
> > MXMLFlexJSPublisher and associated classes.
> >
> > My changes are in the feature-autobuild/closure-classpath-sources
> branch.
> >
> > Chris
> >
> >
> >
> >
>
--
Carlos Rovira
Director General
M: +34 607 22 60 05
http://www.codeoscopic.com
http://www.avant2.es
Este mensaje se dirige exclusivamente a su destinatario y puede contener
información privilegiada o confidencial. Si ha recibido este mensaje por
error, le rogamos que nos lo comunique inmediatamente por esta misma vía y
proceda a su destrucción.
De la vigente Ley Orgánica de Protección de Datos (15/1999), le comunicamos
que sus datos forman parte de un fichero cuyo responsable es CODEOSCOPIC
S.A. La finalidad de dicho tratamiento es facilitar la prestación del
servicio o información solicitados, teniendo usted derecho de acceso,
rectificación, cancelación y oposición de sus datos dirigiéndose a nuestras
oficinas c/ Paseo de la Habana 9-11, 28036, Madrid con la documentación
necesaria.