You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Jon Weygandt (JIRA)" <ji...@apache.org> on 2010/01/06 20:34:54 UTC

[jira] Updated: (SHINDIG-1257) Allow extensions to JsonRpcHandler, plus bug fixes

     [ https://issues.apache.org/jira/browse/SHINDIG-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Weygandt updated SHINDIG-1257:
----------------------------------

    Attachment: 100106-JsonRpc.patch

Code review at: http://codereview.appspot.com/183130

> Allow extensions to JsonRpcHandler, plus bug fixes
> --------------------------------------------------
>
>                 Key: SHINDIG-1257
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1257
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Java
>    Affects Versions: 1.1-BETA5
>            Reporter: Jon Weygandt
>            Priority: Critical
>         Attachments: 100106-JsonRpc.patch
>
>
> Bug fix: altered the loop from a do/while to a simple while. Turns out, if there are no gadgets being requested, the do/while goes into an infinite wait, as "take()" will never return. A possible DOS attack vector, simply use up all the servlet processing threads. For this reason, I set the priority to Critical.
> Allow extensions to modify (generally add) metadata as part of JsonRpcHandler.Job, by Guicing JsonRpcHandler and extending Job.
> Enhancement: views may have attributes, they are now returned as part of the view metadata.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.