You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/14 23:25:13 UTC

[GitHub] [fineract] hmg65 commented on a diff in pull request #2578: FINERACT-1732: Introduce Lombok to bulkimport module

hmg65 commented on code in PR #2578:
URL: https://github.com/apache/fineract/pull/2578#discussion_r971378623


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/data/BulkImportEvent.java:
##########
@@ -18,19 +18,21 @@
  */
 package org.apache.fineract.infrastructure.bulkimport.data;
 
+import lombok.Getter;
 import org.apache.fineract.infrastructure.core.domain.FineractContext;
 import org.apache.fineract.infrastructure.core.domain.FineractEvent;
 import org.apache.poi.ss.usermodel.Workbook;
 
+@Getter
 public final class BulkImportEvent extends FineractEvent {
 
-    private final Workbook workbook;
+    private Workbook workbook;

Review Comment:
   done



##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/domain/FineractEvent.java:
##########
@@ -23,7 +23,7 @@
 
 public abstract class FineractEvent extends ApplicationEvent implements ContextHolder, Serializable {
 
-    private final FineractContext context;
+    private FineractContext context;

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org