[jira] [Commented] (DERBY-6162) Simplify privileged actions in NetworkServerControlApiTest

["Dag H. Wanvik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627790#comment-13627790 ] 

Dag H. Wanvik commented on DERBY-6162:
--------------------------------------

Looks good. I see you added a -Xlint option; is that our current convention? +1


                
> Simplify privileged actions in NetworkServerControlApiTest
> ----------------------------------------------------------
>
>                 Key: DERBY-6162
>                 URL: https://issues.apache.org/jira/browse/DERBY-6162
>             Project: Derby
>          Issue Type: Improvement
>          Components: Test
>    Affects Versions: 10.11.0.0
>            Reporter: Knut Anders Hatlen
>            Assignee: Knut Anders Hatlen
>            Priority: Trivial
>         Attachments: d6162-1a.diff
>
>
> Noticed two privileged blocks in NetworkServerControlApiTest that could be simplified:
> - privInetAddressGetByName() tests whether the PrivilegedActionException wraps a SecurityException. PAE only wraps checked exceptions, and SecurityException is an unchecked exception, so that can never happen.
> - fileExists() could use the existing helper method PrivilegedFileOpsForTests.exists() and remove its privileged block.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira