You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2014/01/03 23:58:37 UTC

Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1626
    https://issues.apache.org/jira/browse/OOZIE-1626


Repository: oozie-git


Description
-------

If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.

Writing to external child id is skipped if job id ==null.


Diffs
-----

  sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java 8fa5ec8 
  sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
  sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 
  sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java e45c8b2 
  sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java ce8a09b 

Diff: https://reviews.apache.org/r/16626/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/#review31248
-----------------------------------------------------------

Ship it!


- Rohini Palaniswamy


On Jan. 5, 2014, 6:32 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16626/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2014, 6:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1626
>     https://issues.apache.org/jira/browse/OOZIE-1626
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.
> 
> Writing to external child id is skipped if job id ==null.
> 
> 
> Diffs
> -----
> 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
>   sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 
> 
> Diff: https://reviews.apache.org/r/16626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>


Re: Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/#review31377
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On Jan. 8, 2014, 1:06 a.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16626/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2014, 1:06 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1626
>     https://issues.apache.org/jira/browse/OOZIE-1626
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.
> 
> Writing to external child id is skipped if job id ==null.
> 
> 
> Diffs
> -----
> 
>   sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
>   sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
>   sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 
>   webapp/src/main/webapp/oozie-console.js e1b4588 
> 
> Diff: https://reviews.apache.org/r/16626/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>


Re: Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/
-----------------------------------------------------------

(Updated Jan. 8, 2014, 1:06 a.m.)


Review request for oozie.


Bugs: OOZIE-1626
    https://issues.apache.org/jira/browse/OOZIE-1626


Repository: oozie-git


Description
-------

If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.

Writing to external child id is skipped if job id ==null.


Diffs
-----

  sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
  sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 
  webapp/src/main/webapp/oozie-console.js e1b4588 

Diff: https://reviews.apache.org/r/16626/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/
-----------------------------------------------------------

(Updated Jan. 8, 2014, 1:05 a.m.)


Review request for oozie.


Changes
-------

jobid.split() length check on UI.


Bugs: OOZIE-1626
    https://issues.apache.org/jira/browse/OOZIE-1626


Repository: oozie-git


Description
-------

If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.

Writing to external child id is skipped if job id ==null.


Diffs (updated)
-----

  sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
  sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 
  webapp/src/main/webapp/oozie-console.js e1b4588 

Diff: https://reviews.apache.org/r/16626/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/
-----------------------------------------------------------

(Updated Jan. 8, 2014, 12:12 a.m.)


Review request for oozie.


Changes
-------

jobid.split() length check on UI.


Bugs: OOZIE-1626
    https://issues.apache.org/jira/browse/OOZIE-1626


Repository: oozie-git


Description
-------

If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.

Writing to external child id is skipped if job id ==null.


Diffs (updated)
-----

  sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
  sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 
  webapp/src/main/webapp/oozie-console.js e1b4588 

Diff: https://reviews.apache.org/r/16626/diff/


Testing
-------


Thanks,

Purshotam Shah


Re: Review Request 16626: [OOZIE-1626]pig action pop-up is not working properly in UI

Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16626/
-----------------------------------------------------------

(Updated Jan. 5, 2014, 6:32 p.m.)


Review request for oozie.


Changes
-------

Updated patch


Bugs: OOZIE-1626
    https://issues.apache.org/jira/browse/OOZIE-1626


Repository: oozie-git


Description
-------

If there are multiple pig job failure with externalChildIDs as "null,null,...", UI popup doesn't show up.

Writing to external child id is skipped if job id ==null.


Diffs (updated)
-----

  sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java 2864898 
  sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java 2814db2 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/PigTestCase.java 9e09395 
  sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMain.java d19d4dd 

Diff: https://reviews.apache.org/r/16626/diff/


Testing
-------


Thanks,

Purshotam Shah