You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/16 03:01:16 UTC
[GitHub] [incubator-dolphinscheduler] gaojun2048 opened a new issue #3754: [Feature][Alert] Alert module support service for other service invoke
gaojun2048 opened a new issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754
This is a sub issue of https://github.com/apache/incubator-dolphinscheduler/issues/3049
In this feature , Alert server is a message notification service , email and wechat is a plugin of this service . If you want send email message you can create an instance of email plugin in the alert group and then you can select the alert group in SqlTask . SqlTask can call the alert server api with this alert group arrguement to send the message.
So we need alert api to support other service invoke.
Now the alert service sends alarms abnormally by periodically scanning the records in table t_ds_alert. It is asynchronous.
In the SqlTask task case, the task need send message synchronous and the final running status of this task depends on whether the message is sent successfully. So the alert api need send messages synchronously.
**the params of alert api :**
* **alert group id** : requied, One or more alert plugin instances are associated with an alert group, and these alert plugin instances will be called in turn when sending a message.
* **title** : requied, the title of this alert message.
* **content**: requied, the content of this alert message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
hermeshephaestus commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-705987668
Good job! I will have a look at the branch /tree/alert_plugin_design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-705942010
> OK, I will create an issue soon and show my design ideas in the mail. @gaojun2048
Hi, What branch are you read about the code of dolphinscheduler-alert?
We have redesigned the code of dolphinscheduler-alert, under this branch, you can look at it again.
https://github.com/apache/incubator-dolphinscheduler/tree/alert_plugin_design
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
hermeshephaestus commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-705987668
Good job! I will have a look at the branch /tree/alert_plugin_design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs closed issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
CalvinKirs closed issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] CalvinKirs commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-731581479
close by #3754
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-705942538
Hi All, I have created a branch https://github.com/apache/incubator-dolphinscheduler/tree/alert_plugin_design to work on this big feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
hermeshephaestus commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-703133999
OK, I have read dolphinscheduler-alert's code, i think it can reference dubbo's design, and the core class EmailAlertPlugin has serious coupling, it can be optimized. I can complete this future. @gaojun2048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] hermeshephaestus commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
hermeshephaestus commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-703361908
OK, I will create an issue soon and show my design ideas in the mail. @gaojun2048
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-705942010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-dolphinscheduler] gaojun2048 commented on issue #3754: [Feature][Alert] Alert module support service for other service invoke
Posted by GitBox <gi...@apache.org>.
gaojun2048 commented on issue #3754:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3754#issuecomment-703182141
> OK, I have read dolphinscheduler-alert's code, i think it can reference dubbo's design, and the core class EmailAlertPlugin has serious coupling, it can be optimized. I can complete this future. @gaojun2048
That's great. Can you create an issue first? Describe your idea, and then you can start.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org