You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2016/02/10 06:28:10 UTC

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/709

    testSparkInterpreterDependencyLoading does not check for endToEndTestEnabled

    ### What is this PR for?
    This is a fix for selenium test case `testSparkInterpreterDependencyLoading` that does not check for `endToEndTestEnabled` causing build to fail on local. (`mvn $TEST_FLAG $PROFILE -B`)
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - Fix for testSparkInterpreterDependencyLoading
    * [x] - delete created notebook for cleanup.
    
    ### Is there a relevant Jira issue?
    N/A
    
    ### How should this be tested?
    `mvn $TEST_FLAG $PROFILE -B` should not fail on local when env variable "CI" is not set.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/incubator-zeppelin ZEPPELIN-630-SeleniumFix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/709.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #709
    
----
commit bb8ebb564be41ae7a7a8573173e2add78f619bd5
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2016-02-10T05:14:50Z

    testSparkInterpreterDependencyLoading does not check for endToEndTestEnabled

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-183500185
  
    looks good, thanks.
    merging if no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-183187194
  
    @felixcheung  @Leemoonsoo Thanks for the review. I have addressed the comment.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-182249690
  
    Yes, agreed, this is much cleaner.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-182692891
  
    @felixcheung have replaced all "ElementNotVisibleException" to "Exception", and then log the same.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/709


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-182696258
  
    looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-182240638
  
    I think it's fine keeping this in #706 - either way is ok with me.
    Much easier to see diff this way: https://github.com/apache/incubator-zeppelin/pull/709/files?w=1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: testSparkInterpreterDependencyLoa...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/709#issuecomment-183614505
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---