You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by jv...@apache.org on 2011/12/14 01:59:40 UTC
svn commit: r1214011 - in /hive/trunk:
contrib/src/test/results/clientnegative/
contrib/src/test/results/clientpositive/ hbase-handler/src/test/results/
ql/src/test/org/apache/hadoop/hive/ql/ ql/src/test/results/clientnegative/
ql/src/test/results/clie...
Author: jvs
Date: Wed Dec 14 00:59:16 2011
New Revision: 1214011
URL: http://svn.apache.org/viewvc?rev=1214011&view=rev
Log:
HIVE-1040 [jira] use sed rather than diff for masking out noise in diff-based
tests
(Marek Sapota via John Sichi)
Summary:
Replace diff -I with regex masking in Java
The current diff -I approach has two problems: (1) it does not allow resolution
finer than line-level, so it's impossible to mask out pattern occurrences within
a line, and (2) it produces unmasked files, so if you run diff on the command
line to compare the result .q.out with the checked-in file, you see the noise.
My suggestion is to first run sed to replace noise patterns with an
unlikely-to-occur string like ZYZZYZVA, and then diff the pre-masked files
without using any -I.
This would require a one-time hit to update all existing .q.out files so that
they would contain the pre-masked results.
Test Plan: EMPTY
Reviewers: JIRA, jsichi
Reviewed By: jsichi
CC: jsichi
Differential Revision: 597
[This commit notification would consist of 64 parts,
which exceeds the limit of 50 ones, so it was shortened to the summary.]