You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/29 22:58:08 UTC
[GitHub] [fineract] vorburger opened a new pull request #1127: make ApiParameterError (almost) immutable
vorburger opened a new pull request #1127:
URL: https://github.com/apache/fineract/pull/1127
by making (most of) its fields final, because Immutable is Good
Only "almost" / "most" because of the of the remaining use of setParameterName() in
EntityDatatableChecksWritePlatformServiceImpl.saveDatatables() which unfortunately looks
a lot less trivial to get rid of, so that's for another time/someone else, later (or never).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #1127: make ApiParameterError (almost) immutable
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #1127:
URL: https://github.com/apache/fineract/pull/1127#issuecomment-651489251
@vorburger looks good to me. I'm assuming the build failure is due to https://issues.apache.org/jira/browse/FINERACT-885?focusedCommentId=17120596&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17120596 - and should resolve itself on 1st July.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1127: make ApiParameterError (almost) immutable
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1127:
URL: https://github.com/apache/fineract/pull/1127#issuecomment-652316281
Test Failure here was NOT just due to FINERACT-1016, but another problem:
```
AccountNumberPreferencesTest > testAccountNumberPreferences() FAILED
java.lang.AssertionError: 1 expectation failed.
Expected status code <400> but was <500>.
```
I'll look more into this under FINERACT-1064.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1127: make ApiParameterError (almost) immutable
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1127:
URL: https://github.com/apache/fineract/pull/1127#issuecomment-651801795
/rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1127: make ApiParameterError (almost) immutable [FINERACT-1064]
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1127:
URL: https://github.com/apache/fineract/pull/1127#issuecomment-652917439
/rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1127: make ApiParameterError (almost) immutable [FINERACT-1064]
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1127:
URL: https://github.com/apache/fineract/pull/1127
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1127: make ApiParameterError (almost) immutable [FINERACT-1064]
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1127:
URL: https://github.com/apache/fineract/pull/1127#issuecomment-652921689
/rebase
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1127: make ApiParameterError (almost) immutable
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1127:
URL: https://github.com/apache/fineract/pull/1127#issuecomment-651412138
@ptuomola would you like to code review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org