You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/03/14 08:25:17 UTC
[PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
lhotari opened a new pull request, #845:
URL: https://github.com/apache/pulsar-site/pull/845
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #845:
URL: https://github.com/apache/pulsar-site/pull/845#discussion_r1524456332
##########
contribute/document-preview.md:
##########
@@ -18,9 +18,17 @@ Pulsar documentation is built using [Docusaurus](https://docusaurus.io/). To pre
To verify docs are built correctly before submitting a contribution, you should set up your local environment to build and display the docs locally.
* Node >= 16.14
-* Yarn >= 1.5
+* Corepack installed and enabled (`corepack enable`)
* Although you can use Linux, macOS, or Windows to build locally the Pulsar documentation, macOS is the preferred build environment as it offers the most complete support for documentation building.
+Installing prerequisites with [homebrew](https://brew.sh/) on MacOS or Linux:
+
+```shell
+brew install node
+brew install corepack
Review Comment:
Not sure about the `brew install` step.
Corepack should be already available on newer Node without involving external package managers. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle merged PR #845:
URL: https://github.com/apache/pulsar-site/pull/845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #845:
URL: https://github.com/apache/pulsar-site/pull/845#discussion_r1524456332
##########
contribute/document-preview.md:
##########
@@ -18,9 +18,17 @@ Pulsar documentation is built using [Docusaurus](https://docusaurus.io/). To pre
To verify docs are built correctly before submitting a contribution, you should set up your local environment to build and display the docs locally.
* Node >= 16.14
-* Yarn >= 1.5
+* Corepack installed and enabled (`corepack enable`)
* Although you can use Linux, macOS, or Windows to build locally the Pulsar documentation, macOS is the preferred build environment as it offers the most complete support for documentation building.
+Installing prerequisites with [homebrew](https://brew.sh/) on MacOS or Linux:
+
+```shell
+brew install node
+brew install corepack
Review Comment:
Not sure about the `brew install` step. Agree with the `corepack enable` step.
Corepack should be already available on newer Node without involving os-wide package managers. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #845:
URL: https://github.com/apache/pulsar-site/pull/845#discussion_r1524456332
##########
contribute/document-preview.md:
##########
@@ -18,9 +18,17 @@ Pulsar documentation is built using [Docusaurus](https://docusaurus.io/). To pre
To verify docs are built correctly before submitting a contribution, you should set up your local environment to build and display the docs locally.
* Node >= 16.14
-* Yarn >= 1.5
+* Corepack installed and enabled (`corepack enable`)
* Although you can use Linux, macOS, or Windows to build locally the Pulsar documentation, macOS is the preferred build environment as it offers the most complete support for documentation building.
+Installing prerequisites with [homebrew](https://brew.sh/) on MacOS or Linux:
+
+```shell
+brew install node
+brew install corepack
Review Comment:
Not sure about the `brew install` step.
Corepack should be already available on newer Node without involving os-wide package managers. Let me check.
Agree with the `corepack enable` step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #845:
URL: https://github.com/apache/pulsar-site/pull/845#discussion_r1524456332
##########
contribute/document-preview.md:
##########
@@ -18,9 +18,17 @@ Pulsar documentation is built using [Docusaurus](https://docusaurus.io/). To pre
To verify docs are built correctly before submitting a contribution, you should set up your local environment to build and display the docs locally.
* Node >= 16.14
-* Yarn >= 1.5
+* Corepack installed and enabled (`corepack enable`)
* Although you can use Linux, macOS, or Windows to build locally the Pulsar documentation, macOS is the preferred build environment as it offers the most complete support for documentation building.
+Installing prerequisites with [homebrew](https://brew.sh/) on MacOS or Linux:
+
+```shell
+brew install node
+brew install corepack
Review Comment:
Not sure about the `brew install` step.
Corepack should be already available on newer Node without involving os-wide package managers. Let me check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "visortelle (via GitHub)" <gi...@apache.org>.
visortelle commented on code in PR #845:
URL: https://github.com/apache/pulsar-site/pull/845#discussion_r1524467220
##########
contribute/document-preview.md:
##########
@@ -18,9 +18,17 @@ Pulsar documentation is built using [Docusaurus](https://docusaurus.io/). To pre
To verify docs are built correctly before submitting a contribution, you should set up your local environment to build and display the docs locally.
* Node >= 16.14
-* Yarn >= 1.5
+* Corepack installed and enabled (`corepack enable`)
* Although you can use Linux, macOS, or Windows to build locally the Pulsar documentation, macOS is the preferred build environment as it offers the most complete support for documentation building.
+Installing prerequisites with [homebrew](https://brew.sh/) on MacOS or Linux:
+
+```shell
+brew install node
+brew install corepack
Review Comment:
Node.js v20.x.x (LTS)
<img width="681" alt="Screenshot 2024-03-14 at 12 45 05 PM" src="https://github.com/apache/pulsar-site/assets/9302460/32cbe62b-f72e-4e93-9738-ee8361f41fa0">
Same for v21.x.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update prerequisites for preview.sh: corepack is required [pulsar-site]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #845:
URL: https://github.com/apache/pulsar-site/pull/845#discussion_r1524493193
##########
contribute/document-preview.md:
##########
@@ -18,9 +18,17 @@ Pulsar documentation is built using [Docusaurus](https://docusaurus.io/). To pre
To verify docs are built correctly before submitting a contribution, you should set up your local environment to build and display the docs locally.
* Node >= 16.14
-* Yarn >= 1.5
+* Corepack installed and enabled (`corepack enable`)
* Although you can use Linux, macOS, or Windows to build locally the Pulsar documentation, macOS is the preferred build environment as it offers the most complete support for documentation building.
+Installing prerequisites with [homebrew](https://brew.sh/) on MacOS or Linux:
+
+```shell
+brew install node
+brew install corepack
Review Comment:
Thanks, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org