You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tibor17 <gi...@git.apache.org> on 2015/04/04 22:18:02 UTC
[GitHub] maven-surefire pull request: [SUREFIRE-1024] "verify" goal ignores...
GitHub user Tibor17 opened a pull request:
https://github.com/apache/maven-surefire/pull/87
[SUREFIRE-1024] "verify" goal ignores "dependenciesToScan" parameter when checking tests existence
The problem of SUREFIRE-1024 was with failsafe plugin which however executed integration-test phase with making a report but did not execute verify phase on POM with packaging POM.
The plugin execution is avoided with printing "No tests to run." if `existsSummary()` returns false.
In the old code the execution was avoided if test-classes was not found, which was strange because the ITs were executed anyway without test-classes. Nowadays no-reports means nothing to verify which looks more logical in `VerifyMojo.java`.
The old functionality still exists, so that in throwing `MojoFailureException( "No tests to run!" )` if test-classes do not exist AND FailIfNoTests==true.
Additionally improved branching in `execute()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tibor17/maven-surefire s4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/maven-surefire/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit ad5dc01cd95390a2315c6066637c8594f37a7195
Author: Tibor17 <ti...@lycos.com>
Date: 2015-04-04T19:56:46Z
[SUREFIRE-1024] "verify" goal ignores "dependenciesToScan" parameter when checking tests existence
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[GitHub] maven-surefire pull request: [SUREFIRE-1024] "verify" goal ignores...
Posted by Tibor17 <gi...@git.apache.org>.
Github user Tibor17 closed the pull request at:
https://github.com/apache/maven-surefire/pull/87
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org