You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Sumit Mohanty <sm...@hortonworks.com> on 2016/02/22 15:10:57 UTC
Review Request 43831: Ambari's App Timeline Web UI Alert tries make
http heavy call timelineserver:httpPort which can also cause OOM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43831/
-----------------------------------------------------------
Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
Bugs: AMBARI-15123
https://issues.apache.org/jira/browse/AMBARI-15123
Repository: ambari
Description
-------
Change the path to call during alert
Diffs
-----
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json bbf3a7c
Diff: https://reviews.apache.org/r/43831/diff/
Testing
-------
Manually tested by editing alert defintion of a deployed cluster
Thanks,
Sumit Mohanty
Re: Review Request 43831: Ambari's App Timeline Web UI Alert tries
make http heavy call timelineserver:httpPort which can also cause OOM
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43831/#review120148
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Feb. 22, 2016, 9:10 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43831/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 9:10 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
>
>
> Bugs: AMBARI-15123
> https://issues.apache.org/jira/browse/AMBARI-15123
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the path to call during alert
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json bbf3a7c
>
> Diff: https://reviews.apache.org/r/43831/diff/
>
>
> Testing
> -------
>
> Manually tested by editing alert defintion of a deployed cluster
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 43831: Ambari's App Timeline Web UI Alert tries
make http heavy call timelineserver:httpPort which can also cause OOM
Posted by Sumit Mohanty <sm...@hortonworks.com>.
> On Feb. 22, 2016, 2:12 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json, line 391
> > <https://reviews.apache.org/r/43831/diff/1/?file=1264104#file1264104line391>
> >
> > Jonathan, one question: It's not critical to update the definiton during Ambari upgrade. However, do we have any example of making alert definition changes during upgrade?
>
> Jonathan Hurley wrote:
> Yeah; the upgrade packs have this already. Here's one: https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java#L1128
Thanks. I have opened https://issues.apache.org/jira/browse/AMBARI-15130 for the upgarde catalog change.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43831/#review120139
-----------------------------------------------------------
On Feb. 22, 2016, 2:10 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43831/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 2:10 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
>
>
> Bugs: AMBARI-15123
> https://issues.apache.org/jira/browse/AMBARI-15123
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the path to call during alert
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json bbf3a7c
>
> Diff: https://reviews.apache.org/r/43831/diff/
>
>
> Testing
> -------
>
> Manually tested by editing alert defintion of a deployed cluster
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 43831: Ambari's App Timeline Web UI Alert tries
make http heavy call timelineserver:httpPort which can also cause OOM
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On Feb. 22, 2016, 9:12 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json, line 391
> > <https://reviews.apache.org/r/43831/diff/1/?file=1264104#file1264104line391>
> >
> > Jonathan, one question: It's not critical to update the definiton during Ambari upgrade. However, do we have any example of making alert definition changes during upgrade?
Yeah; the upgrade packs have this already. Here's one: https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog210.java#L1128
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43831/#review120139
-----------------------------------------------------------
On Feb. 22, 2016, 9:10 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43831/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 9:10 a.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
>
>
> Bugs: AMBARI-15123
> https://issues.apache.org/jira/browse/AMBARI-15123
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the path to call during alert
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json bbf3a7c
>
> Diff: https://reviews.apache.org/r/43831/diff/
>
>
> Testing
> -------
>
> Manually tested by editing alert defintion of a deployed cluster
>
>
> Thanks,
>
> Sumit Mohanty
>
>
Re: Review Request 43831: Ambari's App Timeline Web UI Alert tries
make http heavy call timelineserver:httpPort which can also cause OOM
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43831/#review120139
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json (line 391)
<https://reviews.apache.org/r/43831/#comment181517>
Jonathan, one question: It's not critical to update the definiton during Ambari upgrade. However, do we have any example of making alert definition changes during upgrade?
- Sumit Mohanty
On Feb. 22, 2016, 2:10 p.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43831/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2016, 2:10 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk and Jonathan Hurley.
>
>
> Bugs: AMBARI-15123
> https://issues.apache.org/jira/browse/AMBARI-15123
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Change the path to call during alert
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/alerts.json bbf3a7c
>
> Diff: https://reviews.apache.org/r/43831/diff/
>
>
> Testing
> -------
>
> Manually tested by editing alert defintion of a deployed cluster
>
>
> Thanks,
>
> Sumit Mohanty
>
>