You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "pegasas (via GitHub)" <gi...@apache.org> on 2024/04/28 13:31:14 UTC
[PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
pegasas opened a new pull request, #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
fix: https://github.com/apache/dolphinscheduler/issues/15934
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#issuecomment-2081814548
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15935&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "Radeity (via GitHub)" <gi...@apache.org>.
Radeity commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1584765458
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml:
##########
@@ -133,11 +133,6 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
- {{- else }}
- - name: {{ include "dolphinscheduler.fullname" . }}-worker-data
- emptyDir: {}
- - name: {{ include "dolphinscheduler.fullname" . }}-worker-logs
- emptyDir: {}
Review Comment:
Seems like these lines shouldn't be removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#issuecomment-2081815430
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&inNewCodePeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15935&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&inNewCodePeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "qingwli (via GitHub)" <gi...@apache.org>.
qingwli commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1590489619
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -122,10 +122,10 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
- {{- include "dolphinscheduler.sharedStorage.volume" . | nindent 8 }}
- name: config-volume
configMap:
name: {{ include "dolphinscheduler.fullname" . }}-configs
+ {{- include "dolphinscheduler.sharedStorage.volume" . | nindent 8 }}
Review Comment:
Just change from line115 to line 128?
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-worker.yaml:
##########
@@ -133,11 +133,6 @@ spec:
{{- else }}
emptyDir: {}
{{- end }}
- {{- else }}
- - name: {{ include "dolphinscheduler.fullname" . }}-worker-data
- emptyDir: {}
- - name: {{ include "dolphinscheduler.fullname" . }}-worker-logs
- emptyDir: {}
Review Comment:
> Seems like these lines shouldn't be removed?
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1584089931
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -109,11 +109,9 @@ spec:
volumeMounts:
- mountPath: "/opt/dolphinscheduler/logs"
name: {{ include "dolphinscheduler.fullname" . }}-master
- {{- include "dolphinscheduler.sharedStorage.volumeMount" . | nindent 12 }}
Review Comment:
it seems this config is needed,
I adjust the order and fix some config in `worker`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#issuecomment-2081792902
@Gallardot PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1584067928
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -109,11 +109,9 @@ spec:
volumeMounts:
- mountPath: "/opt/dolphinscheduler/logs"
name: {{ include "dolphinscheduler.fullname" . }}-master
- {{- include "dolphinscheduler.sharedStorage.volumeMount" . | nindent 12 }}
- name: config-volume
mountPath: /opt/dolphinscheduler/conf/common.properties
subPath: common.properties
- {{- include "dolphinscheduler.etcd.ssl.volumeMount" . | nindent 12 }}
Review Comment:
Why delete the ssl volume of etcd?
ref: #13924
@qingwli PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1584089676
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -109,11 +109,9 @@ spec:
volumeMounts:
- mountPath: "/opt/dolphinscheduler/logs"
name: {{ include "dolphinscheduler.fullname" . }}-master
- {{- include "dolphinscheduler.sharedStorage.volumeMount" . | nindent 12 }}
- name: config-volume
mountPath: /opt/dolphinscheduler/conf/common.properties
subPath: common.properties
- {{- include "dolphinscheduler.etcd.ssl.volumeMount" . | nindent 12 }}
Review Comment:
it seems this is also needed in `api`,
so I kept this and adjust the order to make it clear to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#issuecomment-2109243640
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15935&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "pegasas (via GitHub)" <gi...@apache.org>.
pegasas closed pull request #15935: [Improvement][Helm] Refactor configmap control in master
URL: https://github.com/apache/dolphinscheduler/pull/15935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Refactor configmap control in master [dolphinscheduler]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#issuecomment-2109245368
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=15935&metric=new_accepted_issues&view=list)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=15935&resolved=false&sinceLeakPeriod=true)
 No data about Coverage
 No data about Duplication
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=15935)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#issuecomment-2081809674
## [Codecov](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15935?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 39.72%. Comparing base [(`5a6c6c3`)](https://app.codecov.io/gh/apache/dolphinscheduler/commit/5a6c6c37f006291bc774ec44fe6d3d6793721195?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`5ef5eae`)](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15935?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: Current head 5ef5eae differs from pull request most recent head 320afaa. Consider uploading reports for the commit 320afaa to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## dev #15935 +/- ##
============================================
- Coverage 39.72% 39.72% -0.01%
+ Complexity 5034 5033 -1
============================================
Files 1349 1349
Lines 45615 45577 -38
Branches 4891 4866 -25
============================================
- Hits 18122 18105 -17
+ Misses 25578 25557 -21
Partials 1915 1915
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dolphinscheduler/pull/15935?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement][Helm] Remove useless configmap control in master [dolphinscheduler]
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot commented on code in PR #15935:
URL: https://github.com/apache/dolphinscheduler/pull/15935#discussion_r1584070743
##########
deploy/kubernetes/dolphinscheduler/templates/statefulset-dolphinscheduler-master.yaml:
##########
@@ -109,11 +109,9 @@ spec:
volumeMounts:
- mountPath: "/opt/dolphinscheduler/logs"
name: {{ include "dolphinscheduler.fullname" . }}-master
- {{- include "dolphinscheduler.sharedStorage.volumeMount" . | nindent 12 }}
Review Comment:
That's fine with me. Why not remove this from `api-server` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org