You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/23 16:07:26 UTC

[GitHub] [pulsar] WJL3333 opened a new issue, #18165: When authentication is disabled. clientAppId always return null

WJL3333 opened a new issue, #18165:
URL: https://github.com/apache/pulsar/issues/18165

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) and found nothing similar.
   
   
   ### Motivation
   
   When authentication is disabled. `PulsarWebResource.clientAppId()` always return null which makes it is difficult for problem tracing.
   
   always show in log _[null]_ where null is clientAppId
   
   ```shell
   org.apache.pulsar.broker.admin.impl.NamespacesBase - [null] Created namespace demo/tests2
   ``` 
   
   and in some code use clientAppId is use for get authentication role.i think we should split the usage of different purpose.
   
   and we can add more http request relate context in origin request log like the form clientIP clientRequestId clientRole and others. 
   
   ### Solution
   
   split when clientAppId is use for role retrive. and remain origin for request log print.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lifepuzzlefun closed issue #18165: [Improvement] When authentication is disabled. clientAppId always return null

Posted by "lifepuzzlefun (via GitHub)" <gi...@apache.org>.

lifepuzzlefun closed issue #18165: [Improvement] When authentication is disabled. clientAppId always return null 
URL: https://github.com/apache/pulsar/issues/18165


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on issue #18165: [Improvement] When authentication is disabled. clientAppId always return null

Posted by GitBox <gi...@apache.org>.

github-actions[bot] commented on issue #18165:
URL: https://github.com/apache/pulsar/issues/18165#issuecomment-1324458370

   The issue had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org