[GitHub] [flink] MartijnVisser commented on a diff in pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…

["MartijnVisser (via GitHub)" <gi...@apache.org>]

MartijnVisser commented on code in PR #22241:
URL: https://github.com/apache/flink/pull/22241#discussion_r1164228321


##########
flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/throwable/FatalExceptionClassifier.java:
##########
@@ -44,13 +44,13 @@ public FatalExceptionClassifier(
     public boolean isFatal(Throwable err, Consumer<Exception> throwableConsumer) {
         if (validator.test(err)) {
             throwableConsumer.accept(throwableMapper.apply(err));
-            return false;
+            return true;

Review Comment:
   > Can you please add a test for this or raise a Jira to cover that?
   
   I would say that a test must be added before a PR like this can be merged. We shouldn't do this later. 
   
   @dannycranmer If this is `@Internal` I think we can break it between versions, unless there are things that rely on this and it actually should have been made public. WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org