Re: svn commit: r1026088 - /incubator/isis/trunk/alternatives/objectstore/sql/pom.xml

[Dan Haywood <dk...@gmail.com>]

For this change, wouldn't it be better to define a profile instead, ie:

<profiles>
<profile>
<id>normal</id>
<activation>
<activeByDefault/>             # or something like this
</activation>
<modules>
<module>sql-impl</module>
</modules>
</profile>
<profile>
<id>integ-test</id>
<modules>
<module>sql-impl</module>
<module>sql-integrationtests</module>
</modules>
</profile>
</profiles>

then, use "mvn -P integ-test" when want to run the integration tests.

Thoughts?
Dan


On 21/10/2010 19:02, kevin@apache.org wrote:
> Author: kevin
> Date: Thu Oct 21 18:02:42 2010
> New Revision: 1026088
>
> URL: http://svn.apache.org/viewvc?rev=1026088&view=rev
> Log:
> sql integration tests disabled by default. You should manually configure the server configurations in:
> \objectstore\sql\integrationtests\src\test\java\org\apache\isis\extensions\sql\objectstore\*.java
> to match your own server configuration before running.
>
> Modified:
>      incubator/isis/trunk/alternatives/objectstore/sql/pom.xml
>
> Modified: incubator/isis/trunk/alternatives/objectstore/sql/pom.xml
> URL: http://svn.apache.org/viewvc/incubator/isis/trunk/alternatives/objectstore/sql/pom.xml?rev=1026088&r1=1026087&r2=1026088&view=diff
> ==============================================================================
> --- incubator/isis/trunk/alternatives/objectstore/sql/pom.xml (original)
> +++ incubator/isis/trunk/alternatives/objectstore/sql/pom.xml Thu Oct 21 18:02:42 2010
> @@ -60,7 +60,7 @@
>
>       <modules>
>           <module>persistor</module>
> -<module>integrationtests</module>
> +<!--<module>integrationtests</module>  -->
>       </modules>
>
>       <dependencyManagement>
> @@ -70,11 +70,13 @@
>                   <artifactId>sql-impl</artifactId>
>                   <version>${project.version}</version>
>               </dependency>
> -<dependency>
> +			<!--
> +<dependency>
>                   <groupId>org.apache.isis.alternatives.objectstore</groupId>
>                   <artifactId>sql-integrationtests</artifactId>
>                   <version>0.1-SNAPSHOT</version>
> -</dependency>
> +</dependency>
> +			-->
>           </dependencies>
>       </dependencyManagement>
>
>
>
>

Re: svn commit: r1026088 - /incubator/isis/trunk/alternatives/objectstore/sql/pom.xml

[Kevin Meyer - KMZ <ke...@kmz.co.za>]

On 21 Oct 2010 at 19:09, Dan Haywood wrote:

> For this change, wouldn't it be better to define a profile instead, ie:
> 

Gotcha! Thanks, yes. And the syntax is:
		<activation>
			<activeByDefault>true</activeByDefault>
		</activation>

By default, the persistance tests are not executed. 
Use "mvn -P integration-tests".

I have an issue with some tables that are not named as expected..ho 
hum.

But at leat the tests are disabled by default.

Benson wrote:

> Use Derby to allow routine tests.

Umm.. I'll take your word for it..