[GitHub] [hive] ayushtkn commented on a change in pull request #2105: HIVE-24924. Optimize checkpointing flow in incremental load.

[GitBox <gi...@apache.org>]

ayushtkn commented on a change in pull request #2105:
URL: https://github.com/apache/hive/pull/2105#discussion_r633253228



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/ReplTxnTask.java
##########
@@ -53,17 +53,6 @@ public int execute() {
     String tableName = work.getTableName();
     ReplicationSpec replicationSpec = work.getReplicationSpec();
     if ((tableName != null) && (replicationSpec != null)) {
-      Table tbl;

Review comment:
       This is checking the replacement info from the table below -
   ```
           tbl = Hive.get().getTable(work.getDbName(), tableName);
           if (!replicationSpec.allowReplacementInto(tbl.getParameters())) {
   ```
   
   But we don't track at table level now, so removed it. Earlier logic was if the table is not found in the catch block it use to check at db level
   ```
    } catch (InvalidTableException e) {
           // In scenarios like import to mm tables, the alloc write id event is generated before create table event.
           try {
             Database database = Hive.get().getDatabase(work.getDbName());
             if (!replicationSpec.allowReplacementInto(database.getParameters())) {
   ```
   So, I have kept it to check always at database level




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org