You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/04 02:58:01 UTC
[GitHub] [doris] Gabriel39 commented on a diff in pull request #15567: [fix](join) fix anti join incorrectly outputs null values
Gabriel39 commented on code in PR #15567:
URL: https://github.com/apache/doris/pull/15567#discussion_r1061099744
##########
be/src/vec/exec/join/vjoin_node_base.cpp:
##########
@@ -47,12 +47,13 @@ VJoinNodeBase::VJoinNodeBase(ObjectPool* pool, const TPlanNode& tnode, const Des
_is_left_semi_anti(_join_op == TJoinOp::LEFT_ANTI_JOIN ||
_join_op == TJoinOp::LEFT_SEMI_JOIN ||
_join_op == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN),
+ _is_anti_join(_join_op == TJoinOp::RIGHT_ANTI_JOIN ||
+ _join_op == TJoinOp::LEFT_ANTI_JOIN ||
+ _join_op == TJoinOp::NULL_AWARE_LEFT_ANTI_JOIN),
_is_outer_join(_match_all_build || _match_all_probe),
- _is_mark_join(tnode.__isset.nested_loop_join_node
Review Comment:
This is reserved for mark join for hash join node so you can just keep this
##########
be/src/vec/exec/join/vnested_loop_join_node.cpp:
##########
@@ -515,7 +515,8 @@ void VNestedLoopJoinNode::_do_filtering_and_update_visited_flags_impl(
}
template <bool SetBuildSideFlag, bool SetProbeSideFlag>
-Status VNestedLoopJoinNode::_do_filtering_and_update_visited_flags(Block* block, bool materialize) {
+Status VNestedLoopJoinNode::_do_filtering_and_update_visited_flags(Block* block, bool materialize,
+ bool filterNull) {
Review Comment:
filter_null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org