[GitHub] [netbeans] mbien commented on a diff in pull request #5666: Upgrade Gradle Tooling API to 8.0.2

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #5666:
URL: https://github.com/apache/netbeans/pull/5666#discussion_r1139444243


##########
extide/libs.gradle/manifest.mf:
##########
@@ -2,4 +2,4 @@ Manifest-Version: 1.0
 AutoUpdate-Show-In-Client: false
 OpenIDE-Module: org.netbeans.modules.libs.gradle/8
 OpenIDE-Module-Localizing-Bundle: org/netbeans/modules/libs/gradle/Bundle.properties
-OpenIDE-Module-Specification-Version: 8.1
+OpenIDE-Module-Specification-Version: 8.0.2.1

Review Comment:
   we could do it where it works and makes sense and not do it where it doesn't?
   e.g nb-javac uses the major version right now to sync to the JDK version it is based on, numbers after that are changed by the system (aka Neil ;))
   
   https://github.com/apache/netbeans/blob/347d63a7b2acd3254b8bb9f6d512c89f4b84a48e/java/libs.nbjavacapi/manifest.mf#L5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists