You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/10 22:16:49 UTC
[GitHub] [pulsar-helm-chart] mkoertgen opened a new pull request #227: Remove breaking labelmap actions, #226, #100
mkoertgen opened a new pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227
Fixes #226
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] Rohlik commented on pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
Rohlik commented on pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1054403222
I just hit on this problem too. Looking forward to see this PR merged 🙏🏽 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] mkoertgen edited a comment on pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
mkoertgen edited a comment on pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1055315804
Hi @michaeljmarshall ,
Yes, meanwhile the prom-operator-team fixed labelmap validation, so this PR can probably be skipped & closed without merging.
Users should be referred to upgrading prom-operator.
We could still ask ourselves why mapping all labels from the pod is a good idea, though.
In my humble opinion, users should be advised to add labels directly to the servicemonitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] mkoertgen commented on pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
mkoertgen commented on pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1055315804
Hi @michaeljmarshall ,
Yes, meanwhile the prom-operator-team fixed labelmap validation, so this PR can probably be skipped & closed without merging.
Users should be referred to upgrading prom-operator.
We could still ask ourselves why mapping all labels from the pod is a good idea, though.
In my humble opiniont, users should be advised to add labels directly to the servicemonitor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] mkoertgen edited a comment on pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
mkoertgen edited a comment on pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1055315804
Hi @michaeljmarshall ,
Yes, meanwhile the prom-operator-team fixed labelmap validation, so this PR can probably be skipped & closed without merging.
Users should be referred to upgrading prom-operator.
We could still ask ourselves why mapping all labels from the pod is a good idea, though.
In my humble opinion, users should be advised to add labels directly to the servicemonitor.
I can change this PR to also include additional label-values.
But meanwhile I am fine with just closing this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] mkoertgen closed pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
mkoertgen closed pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] michaeljmarshall commented on pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1054648279
@mkoertgen - thanks for your contribution. Do we still need this PR? Based on the discussion in https://github.com/prometheus-operator/prometheus-operator/issues/3942, it seems like a prometheus operator bug that is already fixed in `0.54.1`. I only skimmed that issue, so please correct me if I am mistaken. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] Rohlik commented on pull request #227: Remove breaking labelmap actions, #226, #100
Posted by GitBox <gi...@apache.org>.
Rohlik commented on pull request #227:
URL: https://github.com/apache/pulsar-helm-chart/pull/227#issuecomment-1055228421
@michaeljmarshall
Verified with Prometheus Operator `0.54.1` and it works even without this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org