You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by kk...@apache.org on 2018/05/17 16:31:46 UTC
flink git commit: [FLINK-9387] Several log message errors in
queryable-state module.
Repository: flink
Updated Branches:
refs/heads/master 105b30686 -> 15cdc5cc7
[FLINK-9387] Several log message errors in queryable-state module.
This closes #6029.
Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/15cdc5cc
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/15cdc5cc
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/15cdc5cc
Branch: refs/heads/master
Commit: 15cdc5cc799e2ceb78af974d32feff2096f6571e
Parents: 105b306
Author: yanghua <ya...@gmail.com>
Authored: Thu May 17 09:35:29 2018 +0200
Committer: kkloudas <kk...@gmail.com>
Committed: Thu May 17 18:31:03 2018 +0200
----------------------------------------------------------------------
.../flink/queryablestate/network/AbstractServerHandler.java | 2 +-
.../queryablestate/client/proxy/KvStateClientProxyHandler.java | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flink/blob/15cdc5cc/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
----------------------------------------------------------------------
diff --git a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
index a514723..b2f7a47 100644
--- a/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
+++ b/flink-queryable-state/flink-queryable-state-client-java/src/main/java/org/apache/flink/queryablestate/network/AbstractServerHandler.java
@@ -303,7 +303,7 @@ public abstract class AbstractServerHandler<REQ extends MessageBody, RESP extend
LOG.debug("Request {} was successfully answered after {} ms.", request, durationMillis);
stats.reportSuccessfulRequest(durationMillis);
} else {
- LOG.debug("Request {} failed after {} ms : ", request, durationMillis, future.cause());
+ LOG.debug("Request {} failed after {} ms due to: {}", request, durationMillis, future.cause());
stats.reportFailedRequest();
}
}
http://git-wip-us.apache.org/repos/asf/flink/blob/15cdc5cc/flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
----------------------------------------------------------------------
diff --git a/flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java b/flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
index 2e24431..8201305 100644
--- a/flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
+++ b/flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
@@ -197,14 +197,14 @@ public class KvStateClientProxyHandler extends AbstractServerHandler<KvStateRequ
final CompletableFuture<KvStateLocation> cachedFuture = lookupCache.get(cacheKey);
if (!forceUpdate && cachedFuture != null && !cachedFuture.isCompletedExceptionally()) {
- LOG.debug("Retrieving location for state={} of job={} from the cache.", jobId, queryableStateName);
+ LOG.debug("Retrieving location for state={} of job={} from the cache.", queryableStateName, jobId);
return cachedFuture;
}
final KvStateLocationOracle kvStateLocationOracle = proxy.getKvStateLocationOracle(jobId);
if (kvStateLocationOracle != null) {
- LOG.debug("Retrieving location for state={} of job={} from the key-value state location oracle.", jobId, queryableStateName);
+ LOG.debug("Retrieving location for state={} of job={} from the key-value state location oracle.", queryableStateName, jobId);
final CompletableFuture<KvStateLocation> location = new CompletableFuture<>();
lookupCache.put(cacheKey, location);