You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/02/20 15:00:27 UTC

[GitHub] [lucene-solr] noblepaul opened a new pull request #1266: SOLR-14270 export command to have an option to write to a zip file

noblepaul opened a new pull request #1266: SOLR-14270 export command to have an option to write to a zip file
URL: https://github.com/apache/lucene-solr/pull/1266
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] anshumg commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file

Posted by GitBox <gi...@apache.org>.
anshumg commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file
URL: https://github.com/apache/lucene-solr/pull/1266#discussion_r382283413
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/util/ExportTool.java
 ##########
 @@ -390,6 +400,8 @@ void exportDocs() throws Exception {
             //ignore
           }
         }
+        System.out.println("\nTotal Docs exported: "+ (docsWritten.get() -1)+
 
 Review comment:
   @noblepaul  - the precommit failed due to the use of `System.out`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] noblepaul commented on issue #1266: SOLR-14270 export command to have an option to write to a zip file

Posted by GitBox <gi...@apache.org>.
noblepaul commented on issue #1266: SOLR-14270 export command to have an option to write to a zip file
URL: https://github.com/apache/lucene-solr/pull/1266#issuecomment-589471256
 
 
   SOLR-14270 export command to have an option to write to a zip file

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] noblepaul commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file

Posted by GitBox <gi...@apache.org>.
noblepaul commented on a change in pull request #1266: SOLR-14270 export command to have an option to write to a zip file
URL: https://github.com/apache/lucene-solr/pull/1266#discussion_r382324127
 
 

 ##########
 File path: solr/core/src/java/org/apache/solr/util/ExportTool.java
 ##########
 @@ -390,6 +400,8 @@ void exportDocs() throws Exception {
             //ignore
           }
         }
+        System.out.println("\nTotal Docs exported: "+ (docsWritten.get() -1)+
 
 Review comment:
   fixing...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene-solr] noblepaul merged pull request #1266: SOLR-14270 export command to have an option to write to a zip file

Posted by GitBox <gi...@apache.org>.
noblepaul merged pull request #1266: SOLR-14270 export command to have an option to write to a zip file
URL: https://github.com/apache/lucene-solr/pull/1266
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org