[jira] [Work logged] (HIVE-25596) Compress Hive Replication Metrics while storing

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-25596?focusedWorklogId=667448&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-667448 ]

ASF GitHub Bot logged work on HIVE-25596:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Oct/21 05:02
            Start Date: 20/Oct/21 05:02
    Worklog Time Spent: 10m 
      Work Description: aasha commented on a change in pull request #2724:
URL: https://github.com/apache/hive/pull/2724#discussion_r732416554



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/metric/MetricSink.java
##########
@@ -116,14 +118,15 @@ public void run() {
           int totalMetricsSize = metrics.size();
           List<ReplicationMetrics> replicationMetricsList = new ArrayList<>(totalMetricsSize);
           ObjectMapper mapper = new ObjectMapper();
+          MessageSerializer serializer = GzipJSONMessageEncoder.getInstance().getSerializer();
           for (int index = 0; index < totalMetricsSize; index++) {
             ReplicationMetric metric = metrics.removeFirst();
             ReplicationMetrics persistentMetric = new ReplicationMetrics();
             persistentMetric.setDumpExecutionId(metric.getDumpExecutionId());
             persistentMetric.setScheduledExecutionId(metric.getScheduledExecutionId());
             persistentMetric.setPolicy(metric.getPolicy());
-            persistentMetric.setProgress(mapper.writeValueAsString(metric.getProgress()));
-            persistentMetric.setMetadata(mapper.writeValueAsString(metric.getMetadata()));
+            persistentMetric.setProgress(serializer.serialize(mapper.writeValueAsString(metric.getProgress())));
+            persistentMetric.setMetadata(serializer.serialize(mapper.writeValueAsString(metric.getMetadata())));

Review comment:
       what is the size improvement we get with serializing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 667448)
    Remaining Estimate: 0h
            Time Spent: 10m

> Compress Hive Replication Metrics while storing
> -----------------------------------------------
>
>                 Key: HIVE-25596
>                 URL: https://issues.apache.org/jira/browse/HIVE-25596
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Haymant Mangla
>            Assignee: Haymant Mangla
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Compress the json fields of sys.replication_metrics table to optimise RDBMS space usage.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)