[GitHub] [bookkeeper] zymap commented on a diff in pull request #3837: Group and flush add-responses after journal sync

["zymap (via GitHub)" <gi...@apache.org>]

zymap commented on code in PR #3837:
URL: https://github.com/apache/bookkeeper/pull/3837#discussion_r1127213633


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java:
##########
@@ -1093,6 +1100,10 @@ journalFormatVersionToWrite, getBufferedChannelBuilder(),
                                     numEntriesToFlush--;
                                     entry.run();
                                 }
+
+                                if (forceWriteThread.requestProcessor != null) {
+                                    forceWriteThread.requestProcessor.flushPendingResponses();
+                                }

Review Comment:
   Do we need to record [`journalStats.getJournalFlushStats()`](https://github.com/apache/bookkeeper/pull/3837/files#diff-0a79d54e3dfd4bab1d85510ef957f8f4b7ab6f6acd09aadd634b4d7bbee6e1f4R1111) before trigger flushPendingResponses? That would lead the `JournalFlushStats` to include response time.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org