You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/03/27 21:12:01 UTC

[GitHub] utzig commented on a change in pull request #966: Misc BSP fixes

utzig commented on a change in pull request #966: Misc BSP fixes
URL: https://github.com/apache/mynewt-core/pull/966#discussion_r177574077
 
 

 ##########
 File path: hw/mcu/stm/stm32f1xx/include/mcu/stm32f1_bsp.h
 ##########
 @@ -42,6 +42,12 @@ struct stm32f1_uart_cfg {
     IRQn_Type suc_irqn;                 /* NVIC IRQn */
 };
 
+/*
+ * Internal API for stm32f1xx mcu specific code.
+ */
+int hal_gpio_init_af(int pin, uint8_t af_type, enum hal_gpio_pull pull,
 
 Review comment:
   This one is strange... I removed it intentionally because AFs work differently on stm32f1, and on `master` only `i2c` still uses it, so I can only assume you have `I2C_0: 1`. Btw, PR #953 already removed this dependency, but I'm OK with merging temporarily, and I'll remove it again with that PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services