You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "dingshun3016 (via GitHub)" <gi...@apache.org> on 2024/05/20 12:39:23 UTC
[PR] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
dingshun3016 opened a new pull request, #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725
### What changes were proposed in this pull request?
include jetty-util and shade it
### Why are the changes needed?
When reassign or stag retry is enabled, GrpcServer needs to be started. If there is a port conflict during startup and retry is performed, MultiException will be thrown and the following exception will occur, causing the job to fail.The root cause is that uniffle did not include jetty-util related packages.
`ERROR [main] SparkSubmit$$anon$2: spark submit throw error: org/eclipse/jetty/util/MultiException
java.lang.NoClassDefFoundError: org/eclipse/jetty/util/MultiException
at org.apache.uniffle.common.util.RssUtils.isServerPortBindCollision(RssUtils.java:219)
at org.apache.uniffle.common.util.RssUtils.startServiceOnPort(RssUtils.java:197)
at org.apache.uniffle.common.rpc.GrpcServer.start(GrpcServer.java:188)
at org.apache.spark.shuffle.RssShuffleManager.<init>(RssShuffleManager.java:262)
at org.apache.spark.shuffle.DelegationRssShuffleManager.createShuffleManagerInDriver(DelegationRssShuffleManager.java:87)
at org.apache.spark.shuffle.DelegationRssShuffleManager.<init>(DelegationRssShuffleManager.java:60)
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:423)`
Fix: # (issue)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1735] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
Posted by "dingshun3016 (via GitHub)" <gi...@apache.org>.
dingshun3016 commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2124375824
> @dingshun3016 Could you create an issue for this?
Okay, I've created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1735] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
Posted by "dingshun3016 (via GitHub)" <gi...@apache.org>.
dingshun3016 commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2124381548
> Why we need jetty package in client side? @dingshun3016
You can take a look at the stack information above, mainly using the MultiException class in jetty to determine whether it is a port conflict exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1735] fix(client): MultiException class not found when reassign or stage retry is enabled [incubator-uniffle]
Posted by "maobaolong (via GitHub)" <gi...@apache.org>.
maobaolong commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2217472393
@dingshun3016 Thanks for your contributions. And I have another fix seems can resolve more conflict and CNFE, PTAL
https://github.com/apache/incubator-uniffle/pull/1878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1735] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2186025165
I think we could remove this. @dingshun3016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2120436014
## Test Results
2 405 files ±0 2 405 suites ±0 4h 58m 19s :stopwatch: -1s
931 tests ±0 930 :white_check_mark: ±0 1 :zzz: ±0 0 :x: ±0
10 791 runs ±0 10 777 :white_check_mark: ±0 14 :zzz: ±0 0 :x: ±0
Results for commit 89ab7f26. ± Comparison against base commit c3cbdec4.
[test-results]:data:application/gzip;base64,H4sIAC5MS2YC/03Myw7CIBCF4VdpWLsYLhbGlzEjloTYi6Gwanx3oYG2y/Mx/BtzfhxW9uiEgvutY2vy8brfKVD0y5yFa4OYKb/HcoGSt/Vck7U7wUkf/y2/DnDkxwznxRDCEqqENJcmB428zhbNpvVhtaoaXKr7vkbtMk0+5sEM0ks70QstnHBARjqysu8FkQQJpIxVCHZgvz90/KJmEgEAAA==
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2124319605
Why we need jetty package in client side? @dingshun3016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] fix(client): MultiException class not found when reassign or stag retry is enabled [incubator-uniffle]
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi commented on PR #1725:
URL: https://github.com/apache/incubator-uniffle/pull/1725#issuecomment-2124021457
@dingshun3016 Could you create an issue for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org