You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "Bill (GitHub)" <gi...@apache.org> on 2020/01/14 23:03:28 UTC

[GitHub] [geode] Bill opened pull request #4594: GEODE-6833: remove redundant ArchRule and layer spec

This commit has a little ArchUnit cleanup to GEODE-6833 which was just merged.

### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [x] Is your initial contribution a single, squashed commit?

- [x] Does `gradlew build` run cleanly?

- [x] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/4594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4594: GEODE-6833: remove redundant ArchRule and layer spec

Posted by "Bill (GitHub)" <gi...@apache.org>.
Now that we have eliminated all the spurious dependencies (except the test package one), this `ArchRule` is no longer needed as a baseline.

[ Full content available at: https://github.com/apache/geode/pull/4594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] echobravopapa commented on issue #4594: GEODE-6833: remove redundant ArchRule and layer spec

Posted by "echobravopapa (GitHub)" <gi...@apache.org>.
I like where this is headed...
had a couple failures running locally with this PR
`org.apache.geode.internal.cache.persistence.PersistentRecoveryOrderDUnitTest`
`-- testWaitingMemberList
-- testRevokeAHostBeforeInitialization`

[ Full content available at: https://github.com/apache/geode/pull/4594 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org