You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by gi...@apache.org on 2026/07/28 00:55:30 UTC

(datafusion) branch main updated: chore: Squelch "unused code" warning (#23924)

This is an automated email from the ASF dual-hosted git repository.

github-merge-queue[bot] pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new daacd72a17 chore: Squelch "unused code" warning (#23924)
daacd72a17 is described below

commit daacd72a17eb5ecb10f0b649a8db4c6d6e39baca
Author: Neil Conway <ne...@gmail.com>
AuthorDate: Mon Jul 27 20:44:07 2026 -0400

    chore: Squelch "unused code" warning (#23924)
    
    ## Which issue does this PR close?
    
    - N/A
    
    ## Rationale for this change
    
    ```
    $ cargo test -p datafusion-functions-aggregate
    [...]
      warning: associated function `from_parts` is never used
         --> datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs:464:8
    [...]
    ```
    
    Fix this by appropriately gating the compilation of `from_parts`.
    
    ## What changes are included in this PR?
    
    * Squelch unused code warning
    
    ## Are these changes tested?
    
    Yes.
    
    ## Are there any user-facing changes?
    
    No.
---
 datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs | 1 +
 1 file changed, 1 insertion(+)

diff --git a/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs b/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs
index f97aa2cd73..0fd0ad93bf 100644
--- a/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs
+++ b/datafusion/physical-expr/src/expressions/dynamic_filters/mod.rs
@@ -461,6 +461,7 @@ impl DynamicFilterPhysicalExpr {
 
     /// Rebuild a `DynamicFilterPhysicalExpr` from its stored parts. Used by
     /// proto deserialization.
+    #[cfg(any(test, feature = "proto"))]
     fn from_parts(
         children: Vec<Arc<dyn PhysicalExpr>>,
         remapped_children: Option<Vec<Arc<dyn PhysicalExpr>>>,


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org