You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/04/08 08:55:13 UTC

[GitHub] [tvm] masahi commented on pull request #7717: [Vulkan] Support uniform buffer object for passing many scalar arguments

masahi commented on pull request #7717:
URL: https://github.com/apache/tvm/pull/7717#issuecomment-815583670


   @tqchen This is ready for review. 
   
   On the codegen side, UBO is declared in a similar way as push constants, so I made `DeclareStorageVariable` function to declare both storage type.
   
   On the runtime side, I introduced `CreateBuffer` function to declare both device storage buffers and uniform buffers. The change should be straightforward. 
   
   One potentially controversial point could be the use of runtime function `MaxPushConstantsSize()` during codegen, to query the HW param and decide if we should use push constants or UBO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org