You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "vmuddassir-msft (via GitHub)" <gi...@apache.org> on 2023/08/09 17:21:37 UTC

[GitHub] [arrow-rs] vmuddassir-msft commented on a diff in pull request #4573: fix: add support for microsoft onelake

vmuddassir-msft commented on code in PR #4573:
URL: https://github.com/apache/arrow-rs/pull/4573#discussion_r1288937026


##########
object_store/src/azure/mod.rs:
##########
@@ -911,7 +928,13 @@ impl MicrosoftAzureBuilder {
             (true, url, credential, account_name)
         } else {
             let account_name = self.account_name.ok_or(Error::MissingAccount {})?;
-            let account_url = format!("https://{}.blob.core.windows.net", &account_name);
+            let account_url = if account_name.contains("onelake") {

Review Comment:
   @tustvold You can create an account on app.fabric.com. Once you have an account, you can follow the steps mentioned in https://learn.microsoft.com/en-us/fabric/onelake/create-lakehouse-onelake to create a lakehouse and select files to load data.
   
   Clicking on Properties for a file used in the data load will display the Fabric URL and Azure Blob File System (ABFS) path. I have added a unit test object_store/tests/azure_object_store.rs, which uses the OneLake URL scheme for read/write operations.
   
   ![image](https://github.com/apache/arrow-rs/assets/140655500/dcaa6825-b70c-4ee7-b3ca-d4945644441f)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org