[jira] [Commented] (PROTON-1043) Possible typo in messenger.c

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PROTON-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129001#comment-15129001 ] 

ASF subversion and git services commented on PROTON-1043:
---------------------------------------------------------

Commit 8227452984349b3ab5e69489c7d40b6b4ffbf4f5 in qpid-proton's branch refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8227452 ]

PROTON-1043: Fix error in boolean flag check
[discovered both by aconway and Coverity)


> Possible typo in messenger.c
> ----------------------------
>
>                 Key: PROTON-1043
>                 URL: https://issues.apache.org/jira/browse/PROTON-1043
>             Project: Qpid Proton
>          Issue Type: Bug
>            Reporter: Alan Conway
>              Labels: messenger
>
> From mailing list: http://qpid.2158936.n2.nabble.com/Possible-typo-in-messenger-c-td7632895.html
> ----
> Is this an error:
>   if (messenger->flags | PN_FLAGS_CHECK_ROUTES) {
> (line 1498 in messenger.c)?
> Shouldn't it be:
>  if (messenger->flags & PN_FLAGS_CHECK_ROUTES) {
> ----
> In my opinion this comment is correct but I'm not an expert on messenger so wary of fixing without knowing if some of the code controlled by the if statement really should be running even if PN_FLAGS_CHECK_ROUTES is off. Clearly the code is incorrect as it stands I'm just uncertain if the fix suggested is safe or if the code needs review.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)