You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/28 02:11:01 UTC
[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2224: [KYUUBI #2207]Support newly added spark data types: TimestampNTZType
yaooqinn commented on a change in pull request #2224:
URL: https://github.com/apache/incubator-kyuubi/pull/2224#discussion_r836008938
##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/schema/SchemaHelper.scala
##########
@@ -39,6 +44,7 @@ object SchemaHelper {
case _: DecimalType => TTypeId.DECIMAL_TYPE
case DateType => TTypeId.DATE_TYPE
case TimestampType => TTypeId.TIMESTAMP_TYPE
+ case ntz if ntz.getClass.getName.equals(TIMESTAMP_NTZ) => TTypeId.TIMESTAMP_TYPE
Review comment:
why not use simple class name as intervals?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org