[GitHub] [logging-log4j2] jvz commented on a diff in pull request #1199: LOG4J2-3228 - Remove support for java.io.Serializable

[GitBox <gi...@apache.org>]

jvz commented on code in PR #1199:
URL: https://github.com/apache/logging-log4j2/pull/1199#discussion_r1070432082


##########
log4j-api/src/main/java/org/apache/logging/log4j/message/ObjectMessage.java:
##########
@@ -115,28 +108,14 @@ private boolean equalObjectsOrStrings(final Object left, final Object right) {
 
     @Override
     public int hashCode() {
-        return obj != null ? obj.hashCode() : 0;
+        return obj.hashCode();

Review Comment:
   ```
       public ObjectMessage(final Object obj) {
           this.obj = obj == null ? "null" : obj;
       }
   ```
   
   Doesn't matter if they do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org