[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #2520: [hotfix][engine][dag] The index of the task should start at 0

[GitBox <gi...@apache.org>]

hailin0 commented on code in PR #2520:
URL: https://github.com/apache/incubator-seatunnel/pull/2520#discussion_r954424999


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlanGenerator.java:
##########
@@ -261,7 +261,7 @@ private List<PhysicalVertex> getEnumeratorTask(List<SourceAction<?, ?, ?>> sourc
         return sources.stream().map(s -> {
             long taskGroupID = idGenerator.getNextId();
             SourceSplitEnumeratorTask<?> t = new SourceSplitEnumeratorTask<>(jobImmutableInformation.getJobId(),
-                new TaskLocation(taskGroupID, convertToTaskID(idGenerator.getNextId(), 1)), s);
+                new TaskLocation(taskGroupID, convertToTaskID(idGenerator.getNextId(), 0)), s);

Review Comment:
   Does it need fixing elsewhere?
   
   https://github.com/apache/incubator-seatunnel/blob/st-engine/seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalPlanGenerator.java#L231



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org