You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by dongeforever <gi...@git.apache.org> on 2017/01/19 11:26:50 UTC

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

GitHub user dongeforever opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/46

    [RocketMQ-58] Add integration test for RocketMQ

    Add integration test for RocketMQ

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongeforever/incubator-rocketmq asf_it

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit ea572d8fb559ae631a9b7220d854834acafbfa76
Author: dongeforever <zh...@yeah.net>
Date:   2017-01-19T11:21:15Z

    [RocketMQ-58] Add integration test for RocketMQ

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    
    [![Coverage Status](https://coveralls.io/builds/9744853/badge)](https://coveralls.io/builds/9744853)
    
    Coverage decreased (-0.02%) to 25.667% when pulling **b18eb1d43b1a32d999b7d8328fdf35f195f0ab11 on dongeforever:asf_it** into **4291348ef7ce4f0cd7ff596e5b0c15908e41cf08 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    Also thanks @fenglianghfl for this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96841483
  
    --- Diff: pom.xml ---
    @@ -310,6 +290,7 @@
                                 <encoding>UTF-8</encoding>
                                 <consoleOutput>true</consoleOutput>
                                 <failsOnError>true</failsOnError>
    +                            <includeTestSourceDirectory>false</includeTestSourceDirectory>
    --- End diff --
    
    It could be better if we set `includeTestSourceDirectory ` to `true`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-rocketmq/pull/46


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842859
  
    --- Diff: test/src/test/java/org/apache/rocketmq/test/client/producer/querymsg/QueryMsgByTopicIT.java ---
    @@ -0,0 +1,24 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +
    +package org.apache.rocketmq.test.client.producer.querymsg;
    +
    +public class QueryMsgByTopicIT {
    +//    @Test
    +//    public void test(){
    --- End diff --
    
    Empty class~



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    
    [![Coverage Status](https://coveralls.io/builds/9745617/badge)](https://coveralls.io/builds/9745617)
    
    Coverage decreased (-0.03%) to 25.662% when pulling **2dd1bee4f0e3c4f1e6240df5929460528e64bb0c on dongeforever:asf_it** into **4291348ef7ce4f0cd7ff596e5b0c15908e41cf08 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842460
  
    --- Diff: test/pom.xml ---
    @@ -0,0 +1,52 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one or more
    +  ~ contributor license agreements.  See the NOTICE file distributed with
    +  ~ this work for additional information regarding copyright ownership.
    +  ~ The ASF licenses this file to You under the Apache License, Version 2.0
    +  ~ (the "License"); you may not use this file except in compliance with
    +  ~ the License.  You may obtain a copy of the License at
    +  ~
    +  ~     http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~  Unless required by applicable law or agreed to in writing, software
    +  ~  distributed under the License is distributed on an "AS IS" BASIS,
    +  ~  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  ~  See the License for the specific language governing permissions and
    +  ~  limitations under the License.
    +  -->
    +
    +<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xmlns="http://maven.apache.org/POM/4.0.0"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <parent>
    +        <artifactId>rocketmq-all</artifactId>
    +        <groupId>org.apache.rocketmq</groupId>
    +        <version>4.0.0-SNAPSHOT</version>
    +    </parent>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <artifactId>rocketmq-test</artifactId>
    +
    +
    +    <dependencies>
    +        <dependency>
    --- End diff --
    
    Please use slf4j's logback dependency instead of log4j


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    
    [![Coverage Status](https://coveralls.io/builds/9744547/badge)](https://coveralls.io/builds/9744547)
    
    Coverage decreased (-0.02%) to 25.667% when pulling **7321366ea3827ea98a116727b37ddfbc84edc00f on dongeforever:asf_it** into **4291348ef7ce4f0cd7ff596e5b0c15908e41cf08 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    
    [![Coverage Status](https://coveralls.io/builds/9744547/badge)](https://coveralls.io/builds/9744547)
    
    Coverage decreased (-0.02%) to 25.667% when pulling **7321366ea3827ea98a116727b37ddfbc84edc00f on dongeforever:asf_it** into **4291348ef7ce4f0cd7ff596e5b0c15908e41cf08 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    
    [![Coverage Status](https://coveralls.io/builds/9743612/badge)](https://coveralls.io/builds/9743612)
    
    Coverage decreased (-0.03%) to 25.662% when pulling **ea572d8fb559ae631a9b7220d854834acafbfa76 on dongeforever:asf_it** into **4291348ef7ce4f0cd7ff596e5b0c15908e41cf08 on apache:master**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842213
  
    --- Diff: test/pom.xml ---
    @@ -0,0 +1,52 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one or more
    +  ~ contributor license agreements.  See the NOTICE file distributed with
    +  ~ this work for additional information regarding copyright ownership.
    +  ~ The ASF licenses this file to You under the Apache License, Version 2.0
    +  ~ (the "License"); you may not use this file except in compliance with
    +  ~ the License.  You may obtain a copy of the License at
    +  ~
    +  ~     http://www.apache.org/licenses/LICENSE-2.0
    +  ~
    +  ~  Unless required by applicable law or agreed to in writing, software
    +  ~  distributed under the License is distributed on an "AS IS" BASIS,
    +  ~  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +  ~  See the License for the specific language governing permissions and
    +  ~  limitations under the License.
    +  -->
    +
    +<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    +         xmlns="http://maven.apache.org/POM/4.0.0"
    +         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    +    <parent>
    +        <artifactId>rocketmq-all</artifactId>
    +        <groupId>org.apache.rocketmq</groupId>
    +        <version>4.0.0-SNAPSHOT</version>
    +    </parent>
    +    <modelVersion>4.0.0</modelVersion>
    +
    +    <artifactId>rocketmq-test</artifactId>
    +
    +
    +    <dependencies>
    +        <dependency>
    +            <groupId>log4j</groupId>
    +            <artifactId>log4j</artifactId>
    +            <version>1.2.17</version>
    +        </dependency>
    +        <dependency>
    +            <groupId>${project.groupId}</groupId>
    +            <artifactId>rocketmq-broker</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>${project.groupId}</groupId>
    +            <artifactId>rocketmq-namesrv</artifactId>
    +        </dependency>
    +        <dependency>
    +            <groupId>com.google.truth</groupId>
    --- End diff --
    
    Although Truth is licensed under the open-source Apache 2.0 license. we highly recommended the another counterpart tool assert4j. May be, we can remove this dependency in the near future
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96841726
  
    --- Diff: test/src/main/java/org/apache/rocketmq/test/util/MetaTestUtils.java ---
    @@ -0,0 +1,144 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +
    +package org.apache.rocketmq.test.util;
    +
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.Collections;
    +import java.util.List;
    +import org.apache.rocketmq.client.consumer.PullResult;
    +import org.apache.rocketmq.common.message.Message;
    +import org.apache.rocketmq.common.message.MessageExt;
    +
    +public final class MetaTestUtils {
    +    public static String getMsgBodyString(Message msg) {
    +        if ((null != msg) && (null != msg.getBody())) {
    +            return new String(msg.getBody());
    +        }
    +        return "";
    +    }
    +
    +    public static String printPullMsgList(PullResult pullResult) {
    +        StringBuilder sb = new StringBuilder();
    +        List<MessageExt> msgList = pullResult.getMsgFoundList();
    +        if (msgList == null || msgList.size() == 0) {
    +            sb.append("pull message list is empty");
    +        } else {
    +            sb.append("receive msg is : ");
    +            for (MessageExt msg : msgList) {
    +                sb.append(MetaTestUtils.getMsgBodyString(msg));
    +            }
    +        }
    +        return sb.toString();
    +    }
    +
    +    public static Collection<Object> convertMessageListToStringList(Collection<?> srcLst) {
    +        if (srcLst == null || srcLst.isEmpty()) {
    +            return Collections.emptyList();
    +        }
    +        List<Object> lst = new ArrayList<Object>();
    +        for (Object obj : srcLst) {
    +            if (obj instanceof Message) {
    +                Message msg = (Message) obj;
    +                lst.add(MetaTestUtils.getMsgBodyString(msg));
    +            } else if (obj instanceof byte[]) {
    +                byte[] bytes = (byte[]) obj;
    +                lst.add(new String(bytes));
    +            }
    +        }
    +        return lst;
    +    }
    +
    +
    +    public static String getNamespaceAddress() {
    +//        Application app = MetaTestEnvManager.getInstance().getTestProject()
    +//                .getApplicationByPath("metaBroker-single");
    +//        if (app != null) {
    +//            return app.getProperty("nameAdd");
    +//        }
    +        return "";
    +    }
    +
    +    public static String getHaNameServerAddress() {
    +//        Application app = MetaTestEnvManager.getInstance().getTestProject()
    +//                .getApplicationByPath("metaBroker-master");
    +//        if (app != null) {
    +//            return app.getProperty("nameAdd");
    +//        }
    +        return "";
    +    }
    +
    +    public static String getAddrServerIp() {
    +//        Application app = MetaTestEnvManager.getInstance().getTestProject()
    +//                .getApplicationByPath("metaBroker-single");
    +//        if (app != null) {
    +//            return app.getProperty("addrServIp");
    +//        }
    +        return "";
    +    }
    +
    +    public static String getMachineUser() {
    +//        Application app = MetaTestEnvManager.getInstance().getTestProject()
    +//                .getApplicationByPath("metaBroker-single");
    +//        if (app != null) {
    +//            return app.getProperty("machineUser");
    +//        }
    +        return "";
    +    }
    +
    +    public static String getPasswd() {
    +//        Application app = MetaTestEnvManager.getInstance().getTestProject()
    +//                .getApplicationByPath("metaBroker-single");
    +//        if (app != null) {
    +//            return app.getProperty("machinePassword");
    +//        }
    +        return "";
    +    }
    +
    +
    +
    +
    +
    +
    +
    +
    +
    +
    --- End diff --
    
    Too many blank lines.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842801
  
    --- Diff: test/src/main/java/org/apache/rocketmq/test/factory/MessageFactory.java ---
    @@ -0,0 +1,144 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +
    +package org.apache.rocketmq.test.factory;
    +
    +import java.util.ArrayList;
    +import java.util.Collection;
    +import java.util.List;
    +import org.apache.rocketmq.common.message.Message;
    +import org.apache.rocketmq.test.util.RandomUtils;
    +
    +public class MessageFactory {
    +
    +    public static Message getRandomMessage(String topic) {
    +        return getStringMessage(topic, RandomUtils.getStringByUUID());
    +    }
    +
    +    public static Message getStringMessage(String topic, String body) {
    +        Message msg = new Message(topic, body.getBytes());
    +        return msg;
    +    }
    +
    +    public static Message getStringMessageByTag(String topic, String tags, String body) {
    +        Message msg = new Message(topic, tags, body.getBytes());
    +        return msg;
    +    }
    +
    +    public static Message getRandomMessageByTag(String topic, String tags) {
    +        return getStringMessageByTag(topic, tags, RandomUtils.getStringByUUID());
    +    }
    +
    +    public static Collection<Message> getRandomMessageList(String topic, int size) {
    +        List<Message> msgList = new ArrayList<Message>();
    +        for (int i = 0; i < size; i++) {
    +            msgList.add(getRandomMessage(topic));
    +        }
    +        return msgList;
    +    }
    +
    +//     *
    +//     * @return
    +//     */
    +//    public static Message getStringMessage(MessageEntity entity) {
    +//        if (entity == null || StringUtils.isBlank(entity.getTopic())) {
    +//            return null;
    +//        }
    +//        String s = FastjsonUtils.jsonObject2JsonString(entity);
    +//        Message msg = getStringMessage(entity.getTopic(), s);
    +//        if (entity.getDelayTimeLevel() != 0) {
    +//            msg.setDelayTimeLevel(entity.getDelayTimeLevel());
    +//        }
    +//        return msg;
    +//    }
    +
    +//        if (entity == null || StringUtils.isBlank(entity.getTopic())) {
    +//            return null;
    +//        }
    +//        String s = FastjsonUtils.jsonObject2JsonString(entity);
    +//        return getStringMessageByTag(entity.getTopic(), entity.getTag(), s);
    +//    }
    +
    +//                                                           Collection<MessageEntity> entityList) {
    +//        List<Message> msgList = new ArrayList<Message>();
    +//        for (MessageEntity entry : entityList) {
    +//            String s =FastjsonUtils.jsonObject2JsonString(entry);
    +//            msgList.add(getStringMessage(topic, s));
    +//        }
    +//        return msgList;
    +//    }
    +
    +//                                                                Collection<MessageEntity> strs) {
    +//        List<Message> msgList = new ArrayList<Message>();
    +//        for (MessageEntity entry : strs) {
    +//            String s =FastjsonUtils.jsonObject2JsonString(entry);
    +//            msgList.add(getStringMessageByTag(topic, tags, s));
    +//        }
    +//        return msgList;
    +//    }
    +    public static Collection<Message> getRandomMessageListByTag(String topic, String tags, int size) {
    +        List<Message> msgList = new ArrayList<Message>();
    +        for (int i = 0; i < size; i++) {
    +            msgList.add(getRandomMessageByTag(topic, tags));
    +        }
    +        return msgList;
    +    }
    +
    +//        MessageEntity entity = new MessageEntity();
    --- End diff --
    
    Could you remove these redundant comment code


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #46: [RocketMQ-58] Add integration test for RocketM...

Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/46
  
    Nice job ! Integration failsafe with sonar, that's really a tremendous work. :-) We can merge it now, but it still our polish work in the near future


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq pull request #46: [RocketMQ-58] Add integration test for ...

Posted by zhouxinyu <gi...@git.apache.org>.
Github user zhouxinyu commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/46#discussion_r96842822
  
    --- Diff: test/src/test/java/org/apache/rocketmq/test/client/producer/querymsg/QueryMsgByTopicExceptionIT.java ---
    @@ -0,0 +1,24 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +
    +package org.apache.rocketmq.test.client.producer.querymsg;
    +
    +public class QueryMsgByTopicExceptionIT {
    +//    @Test
    --- End diff --
    
    Empty class~


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---