You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/26 19:17:29 UTC

[GitHub] [airflow] potiuk edited a comment on pull request #20349: Fix Scheduler crash when executing task instances of missing DAG

potiuk edited a comment on pull request #20349:
URL: https://github.com/apache/airflow/pull/20349#issuecomment-1022515427


   I think honestly crashing on data entry is arguably "never" a good thing.
   
   Why the import errors would appear actually ? I am not sure if I "feel" where it comes from. I though such crashes on import might only come from not-yet-synced files (when you are using something else than git-sync - there you have atomic swaps for all files in a commit) but I cannot see how it could lead to missing DAG in serialized table and running tasks at the same time. I thought we can only have running task when we also have serialized dag.
   
   But maybe I am missing something :)
   
   Do we actually have a case that DAG is deleted while being re-generated? Maybe we should fix that instead ?
   
   BTW. AIP-43 will mean that such errors will not crash scheduler either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org