[GitHub] [airflow] bbovenzi commented on a diff in pull request #25067: AIRFLOW-25062: changes for priority

[GitBox <gi...@apache.org>]

bbovenzi commented on code in PR #25067:
URL: https://github.com/apache/airflow/pull/25067#discussion_r922285210


##########
airflow/www/static/js/graph.js:
##########
@@ -36,6 +36,7 @@ const dagRunId = getMetaValue('dag_run_id');
 const arrange = getMetaValue('arrange');
 const taskInstancesUrl = getMetaValue('task_instances_url');
 const isSchedulerRunning = getMetaValue('is_scheduler_running');
+const priority = getMetaValue('priority');

Review Comment:
   Unfortunately this won't work.
   
   To use `getMetaValue()`, we need to add a `<meta>` tag in `graph.html`, but that really only works for simple types like strings
   
   Instead, I'd follow the example of `tasks`, `nodes`, `edges` in `graph/html` and then add `priority` as one of the global declaration at the top of this file.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org