You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2015/02/18 06:30:12 UTC
Review Request 31150: Patch for kafka-1952
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31150/
-----------------------------------------------------------
Review request for kafka.
Bugs: kafka-1952
https://issues.apache.org/jira/browse/kafka-1952
Repository: kafka
Description
-------
kafka-1952
Diffs
-----
core/src/main/scala/kafka/server/DelayedOperation.scala fc06b01cad3a0497800df727fa2abf60772694f2
Diff: https://reviews.apache.org/r/31150/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 31150: Patch for kafka-1952
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31150/#review72907
-----------------------------------------------------------
Ship it!
core/src/main/scala/kafka/server/DelayedOperation.scala
<https://reviews.apache.org/r/31150/#comment119022>
I think we do not use capitalized letter for in-function comments?
- Guozhang Wang
On Feb. 18, 2015, 5:30 a.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31150/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2015, 5:30 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: kafka-1952
> https://issues.apache.org/jira/browse/kafka-1952
>
>
> Repository: kafka
>
>
> Description
> -------
>
> kafka-1952
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/server/DelayedOperation.scala fc06b01cad3a0497800df727fa2abf60772694f2
>
> Diff: https://reviews.apache.org/r/31150/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>