You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/08/20 13:08:58 UTC
[GitHub] [cloudstack] SadiJr opened a new pull request #5351: Externalize vm stats increment in memory
SadiJr opened a new pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351
### Description
CloudStack has a feature to keep and increment the VM metrics in memory. This PR intends to externalize one new configuration, `vm.stats.increment.metrics.in.memory` to allow operators to choose if they want to increment VM metrics or not.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
#### Feature/Enhancement Scale
- [ ] Major
- [x] Minor
### How Has This Been Tested?
KVM hypervisor:
- I created a VM in CloudStack and maked Network and Disk I/O operations
- I changed the value of configuration `vm.stats.increment.metrics.in.memory`
- I checked that the metrics weren't incrementing in memory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-904328624
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-904328215
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
SadiJr commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-902796322
Thanks @DaanHoogland for the review. This feature will allow operators to see real time statistics, what was not possible before. I can't say it will be useful or not, but the important thing, from my point of view, is that this option exists, in case anyone wants to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-903073787
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] SadiJr edited a comment on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
SadiJr edited a comment on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-902796322
Thanks @DaanHoogland for the review. This feature will allow operators to see real time statistics, what was not possible before (because the statistics of NetworkReadKBs, NetworkWriteKBs, DiskWriteKBs, DiskReadKBs, DiskReadIOs and DiskWriteIOs were being incremented in memory). I can't say it will be useful or not, but the important thing, from my point of view, is that this option exists, in case anyone wants to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-904307733
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-904316485
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-904307307
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-903073743
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-903076772
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5351: Externalize vm stats increment in memory
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5351:
URL: https://github.com/apache/cloudstack/pull/5351#issuecomment-904741315
<b>Trillian test result (tid-1758)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34927 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5351-t1758-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_snapshots.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 89 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org