You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jason810496 (via GitHub)" <gi...@apache.org> on 2025/01/31 15:46:58 UTC
[PR] Remove Alembic migration autogenerated comment in #46009 [airflow]
jason810496 opened a new pull request, #46322:
URL: https://github.com/apache/airflow/pull/46322
While rebasing #45961 to the latest main branch and resolving the migration file conflict, I found that the comment was not removed.
related: #46009
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Alembic migration autogenerated comment [airflow]
Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #46322:
URL: https://github.com/apache/airflow/pull/46322#discussion_r1938058138
##########
airflow/migrations/versions/0057_3_0_0_add_new_task_instance_field_scheduled_.py:
##########
@@ -42,23 +42,17 @@
def upgrade():
"""Apply add new task_instance field scheduled_dttm."""
- # ### commands auto generated by Alembic - please adjust! ###
with op.batch_alter_table("task_instance", schema=None) as batch_op:
batch_op.add_column(sa.Column("scheduled_dttm", UtcDateTime(timezone=True), nullable=True))
with op.batch_alter_table("task_instance_history", schema=None) as batch_op:
batch_op.add_column(sa.Column("scheduled_dttm", UtcDateTime(timezone=True), nullable=True))
- # ### end Alembic commands ###
-
Review Comment:
Nice. Can you also do the same for Fab provider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Alembic migration autogenerated comment [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #46322:
URL: https://github.com/apache/airflow/pull/46322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Remove Alembic migration autogenerated comment [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on code in PR #46322:
URL: https://github.com/apache/airflow/pull/46322#discussion_r1938264081
##########
airflow/migrations/versions/0057_3_0_0_add_new_task_instance_field_scheduled_.py:
##########
@@ -42,23 +42,17 @@
def upgrade():
"""Apply add new task_instance field scheduled_dttm."""
- # ### commands auto generated by Alembic - please adjust! ###
with op.batch_alter_table("task_instance", schema=None) as batch_op:
batch_op.add_column(sa.Column("scheduled_dttm", UtcDateTime(timezone=True), nullable=True))
with op.batch_alter_table("task_instance_history", schema=None) as batch_op:
batch_op.add_column(sa.Column("scheduled_dttm", UtcDateTime(timezone=True), nullable=True))
- # ### end Alembic commands ###
-
Review Comment:
Hi @ephraimbuddy, there is only a placeholder migration file in the FAB provider, and it does not contain an Alembic-generated comment. So, I think we can skip it, right?
https://github.com/apache/airflow/blob/main/providers/src/airflow/providers/fab/migrations/versions/0001_1_4_0_placeholder_migration.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org