You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/01/31 00:35:39 UTC

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22427


Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................

[util] improve MaintenanceManagerTest.TestRunningInstances

This patch introduces a ScopedCleanup instance to unregister maintenance
operations registered by MaintenanceManagerTest.TestRunningInstances if
ASSERT_EVENTUALLY triggers.  Also, the timeout for AssertEventually
increased two-fold to reduce flakiness when running on busy nodes.  The
motivation for this patch was seeing the test scenario failing [1] with
the following TSAN warning due to CHECK() in
MaintenanceOp::~MaintenanceOp():

  WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207

Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 19 insertions(+), 13 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/22427/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1000/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 21:32:55 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Ashwani Raina, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22427

to look at the new patch set (#3).

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................

[util] improve MaintenanceManagerTest.TestRunningInstances

This patch introduces a ScopedCleanup instance to unregister maintenance
operations registered by MaintenanceManagerTest.TestRunningInstances if
ASSERT_EVENTUALLY triggers.  Also, the timeout for AssertEventually is
increased two-fold to reduce flakiness when running on busy nodes.  The
motivation for this patch was seeing the test scenario failing [1] with
the following TSAN warning due to CHECK() in
MaintenanceOp::~MaintenanceOp():

  WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207

Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 19 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/22427/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3: Verified+1

unrelated test failures (RELEASE):
  * intermittent failure in synchronizing system's clock
  * KUDU-3635


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 22:02:22 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22427/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22427/2//COMMIT_MSG@11
PS2, Line 11: AssertEventually
> nit: AssertEventually is or AssertEventually has been
Done


http://gerrit.cloudera.org:8080/#/c/22427/2/src/kudu/util/maintenance_manager-test.cc
File src/kudu/util/maintenance_manager-test.cc:

http://gerrit.cloudera.org:8080/#/c/22427/2/src/kudu/util/maintenance_manager-test.cc@643
PS2, Line 643: run
> Is this method available upstream?
https://gerrit.cloudera.org/#/c/22426/



-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 16:05:10 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Mahesh Reddy (Code Review)" <ge...@cloudera.org>.
Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 17:47:35 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3:

> 60 seconds might be a long time if it goes to that point, do we
 > want to use the below macro for this test?
 > SKIP_IF_SLOW_NOT_ALLOWED()

This test scenario usually completes in about 1 second if running  non-TSAN bits on a machine with contemporary hardware, and with TSAN bits it's under 3 seconds.  The outlier runs happen rarely, and a lot of depends on how busy the test node is.

If treating ASSERT_EVENTUALLY the way you suggested, several other tests should be marked with SKIP_IF_SLOW_NOT_ALLOWED(), and I think the best way doing so in a separate changelist.

What do you think?


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 00:09:04 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/995/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 05:58:31 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 05:22:40 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 1:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/991/


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 31 Jan 2025 00:35:43 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1000/


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 19:46:43 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 5:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1036/


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 00:09:11 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3:

> > 60 seconds might be a long time if it goes to that point, do we
 > > want to use the below macro for this test?
 > > SKIP_IF_SLOW_NOT_ALLOWED()
 > 
 > This test scenario usually completes in about 1 second if running 
 > non-TSAN bits on a machine with contemporary hardware, and with
 > TSAN bits it's under 3 seconds.  The outlier runs happen rarely,
 > and a lot of depends on how busy the test node is.
 > 
 > If treating ASSERT_EVENTUALLY the way you suggested, several other
 > tests should be marked with SKIP_IF_SLOW_NOT_ALLOWED(), and I think
 > the best way doing so in a separate changelist.
 > 
 > What do you think?

Ah, it seems the proper fix is different.  I'll post a new PS soon.


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 21:07:54 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/995/


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 04:04:43 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Ashwani Raina, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22427

to look at the new patch set (#4).

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................

[util] improve MaintenanceManagerTest.TestRunningInstances

This patch introduces a ScopedCleanup instance to unregister maintenance
operations registered by MaintenanceManagerTest.TestRunningInstances if
ASSERT_EVENTUALLY triggers.  Also, the timeout for AssertEventually is
increased two-fold to reduce flakiness when running on busy nodes.  The
motivation for this patch was seeing the test scenario failing [1] with
the following TSAN warning due to CHECK() in
MaintenanceOp::~MaintenanceOp():

  WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207

Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 44 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/22427/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 1: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/991/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 02:19:41 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 5: Code-Review+2

Thanks for addressing the issue and the feedback.


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 00:23:06 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 4:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1034/


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 21:26:13 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................

[util] improve MaintenanceManagerTest.TestRunningInstances

This patch introduces a ScopedCleanup instance to unregister maintenance
operations registered by MaintenanceManagerTest.RunningInstances if
ASSERT_EVENTUALLY triggers.  Also, the scenario is now more resilient to
scheduler anomalies.  The motivation for this patch was a report
on test failures [1] with the following TSAN warning due to CHECK()
in MaintenanceOp::~MaintenanceOp():

  WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207

Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Reviewed-on: http://gerrit.cloudera.org:8080/22427
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 44 insertions(+), 15 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 4: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1034/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 05 Feb 2025 22:23:12 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 3: Code-Review+1

60 seconds might be a long time if it goes to that point, do we want to use the below macro for this test?
SKIP_IF_SLOW_NOT_ALLOWED()


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Tue, 04 Feb 2025 23:10:55 +0000
Gerrit-HasComments: No

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Ashwani Raina (Code Review)" <ge...@cloudera.org>.
Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/22427/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22427/2//COMMIT_MSG@11
PS2, Line 11: AssertEventually
nit: AssertEventually is or AssertEventually has been


http://gerrit.cloudera.org:8080/#/c/22427/2/src/kudu/util/maintenance_manager-test.cc
File src/kudu/util/maintenance_manager-test.cc:

http://gerrit.cloudera.org:8080/#/c/22427/2/src/kudu/util/maintenance_manager-test.cc@643
PS2, Line 643: run
Is this method available upstream?



-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Fri, 31 Jan 2025 14:22:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Mahesh Reddy, Ashwani Raina, Yifan Zhang, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22427

to look at the new patch set (#5).

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................

[util] improve MaintenanceManagerTest.TestRunningInstances

This patch introduces a ScopedCleanup instance to unregister maintenance
operations registered by MaintenanceManagerTest.RunningInstances if
ASSERT_EVENTUALLY triggers.  Also, the scenario is now more resilient to
scheduler anomalies.  The motivation for this patch was a report
on test failures [1] with the following TSAN warning due to CHECK()
in MaintenanceOp::~MaintenanceOp():

  WARNING: ThreadSanitizer: data race on vptr (ctor/dtor vs virtual call)

[1] http://dist-test.cloudera.org/job?job_id=jenkins-slave.1738131961.3963207

Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
---
M src/kudu/util/maintenance_manager-test.cc
1 file changed, 44 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/27/22427/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>

[kudu-CR] [util] improve MaintenanceManagerTest.TestRunningInstances

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22427 )

Change subject: [util] improve MaintenanceManagerTest.TestRunningInstances
......................................................................


Patch Set 5: Verified+1

Build Successful 

http://jenkins.kudu.apache.org/job/pre_commit/1036/ : SUCCESS


-- 
To view, visit http://gerrit.cloudera.org:8080/22427
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I95f34e7cb8d37a0da4445012de40abfb2fe6f00e
Gerrit-Change-Number: 22427
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ar...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mr...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Thu, 06 Feb 2025 03:05:04 +0000
Gerrit-HasComments: No