You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@whimsical.apache.org by cu...@apache.org on 2018/05/31 13:24:22 UTC

[whimsy] branch master updated: Uncomment real code and remove TODO DEBUG

This is an automated email from the ASF dual-hosted git repository.

curcuru pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 8374749  Uncomment real code and remove TODO DEBUG
8374749 is described below

commit 8374749647fcaa2d40c68519b539840e46485c16
Author: Shane Curcuru <as...@shanecurcuru.org>
AuthorDate: Thu May 31 09:24:03 2018 -0400

    Uncomment real code and remove TODO DEBUG
---
 www/committers/ldap-map.cgi | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/www/committers/ldap-map.cgi b/www/committers/ldap-map.cgi
index e147645..8736a80 100755
--- a/www/committers/ldap-map.cgi
+++ b/www/committers/ldap-map.cgi
@@ -179,10 +179,6 @@ end
 # Submit the committer's provided mapping of their own IDs
 def submit_form(formdata: {})
   formdata[SUBMITTED_AT] = Time.now.iso8601
-  _div.well do
-    _p 'Your ID Mapping being submitted:'
-    _pre JSON.pretty_generate(formdata) + "\n"
-  end
   rc = 999 # Ensure it's a bogus value
   Dir.mktmpdir do |tmpdir|
     tmpdir.untaint
@@ -198,13 +194,8 @@ def submit_form(formdata: {})
     File.write(filename, JSON.pretty_generate(idmaps))
     
     Dir.chdir tmpdir do
-      message = "#{formdata[COMMITTERID]} JIRA=#{formdata[JIRA]} Confluence=#{formdata[CONFLUENCE]}"
-      _p "DEBUG: commit message = #{message}" # TODO DEBUG: only providing a diff until tested
-      rc = _.system ['svn', 'diff', filename,
+      rc = _.system ['svn', 'commit', filename, '--message', "#{formdata[COMMITTERID]} JIRA=#{formdata[JIRA]} Confluence=#{formdata[CONFLUENCE]}",
         ['--no-auth-cache', '--non-interactive'], credentials]
-      # TODO DEBUG: only providing a diff until tested
-      # rc = _.system ['svn', 'commit', filename, '--message', message,
-      #   ['--no-auth-cache', '--non-interactive'], credentials]
     end
   end
 

-- 
To stop receiving notification emails like this one, please contact
curcuru@apache.org.