You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Tobias Lindaaker (Jira)" <ji...@apache.org> on 2023/10/02 15:07:00 UTC
[jira] [Commented] (CASSANDRA-18893) Upgrade hdrhistogram
[ https://issues.apache.org/jira/browse/CASSANDRA-18893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17771159#comment-17771159 ]
Tobias Lindaaker commented on CASSANDRA-18893:
----------------------------------------------
+1, the change itself is small and simple, and CI looks good.
In my opinion it would make sense to make the same change in 4.0 (and 4.1) as well, since those branches are supposed to support Java 11 as well, and HdrHistogram 2.1.9 contains code that is incompatible with java versions newer than 9.
Since I have seen this issue in the wild, I can perhaps share a bit more insight into what the incompatibility is:
Before version 2.1.10, HdrHistogram uses {{javax.xml.bind.DatatypeConverter}} for BASE64 conversion in the reading and writing of histogram logs. That class does not exist in Java versions later than 9.
Java 1.8 introduced an official API for doing BASE64 encoding and decoding in {{java.util.Base64}}, which was picked up and used by HdrHistogram from version 2.1.10.
> Upgrade hdrhistogram
> --------------------
>
> Key: CASSANDRA-18893
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18893
> Project: Cassandra
> Issue Type: Task
> Components: Dependencies
> Reporter: Ekaterina Dimitrova
> Assignee: Ekaterina Dimitrova
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> We are on 2.1.9, but some breaking changes for J9+ were introduced only in 2.1.10 (we don't hit them in our CI but a user reported they saw NoClassFound in some testing)
> https://github.com/HdrHistogram/HdrHistogram/commit/c410c5c2699b69ce0eb026ff954fefc4045ec363
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org