You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Amit Jain (JIRA)" <ji...@apache.org> on 2018/08/31 08:49:00 UTC
[jira] [Updated] (OAK-7724) BlobGCMbean not registered with
SegmentNodeStoreFactory
[ https://issues.apache.org/jira/browse/OAK-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amit Jain updated OAK-7724:
---------------------------
Attachment: OAK-7724.patch
> BlobGCMbean not registered with SegmentNodeStoreFactory
> -------------------------------------------------------
>
> Key: OAK-7724
> URL: https://issues.apache.org/jira/browse/OAK-7724
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: segment-tar
> Reporter: Amit Jain
> Priority: Major
> Fix For: 1.10
>
> Attachments: OAK-7724.patch
>
>
> SegmentNodeStoreService checks to see if the segment store is primary before registering the BlobGCMbean.
> With SegmentNodeStoreFactory the Configuration#isPrimarySegmentStore is always set to false. The intention is to not register the BlobGC when the the role is secondary in which case the condition should be changed to
> {code}
> ckrabbit/oak/segment/SegmentNodeStoreRegistrar.java
> IDEA additional info:
> Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
> <+>UTF-8
> ===================================================================
> --- oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java (revision 9f1e8bdc6c91ba750ac1eea540fe59ac89ef9114)
> +++ oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeStoreRegistrar.java (date 1535703785000)
> @@ -397,7 +397,7 @@
> }
> }
>
> - if (cfg.isPrimarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore) {
> + if (!cfg.isSecondarySegmentStore() && cfg.getBlobStore() instanceof GarbageCollectableBlobStore) {
> BlobGarbageCollector gc = new MarkSweepGarbageCollector(
> new SegmentBlobReferenceRetriever(store),
> (GarbageCollectableBlobStore) cfg.getBlobStore(),
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)