You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by sudheeshkatkam <gi...@git.apache.org> on 2015/07/15 00:38:10 UTC
[GitHub] drill pull request: DRILL-2304: Case sensitivity - system and sess...
GitHub user sudheeshkatkam opened a pull request:
https://github.com/apache/drill/pull/90
DRILL-2304: Case sensitivity - system and session options are case sensitive
@jaltekruse please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudheeshkatkam/drill DRILL-2304
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/90.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #90
----
commit 313c8e3632fa71a5ed5f62baf1146e8c20f80065
Author: Sudheesh Katkam <sk...@maprtech.com>
Date: 2015-07-14T18:29:56Z
DRILL-2304: Part 1: Documentation for OptionManagers
+ corrected error message in BaseOptionManager
+ use getAdmin in setOption method
commit f33654c7c539863e56958cc1746eded329b73e61
Author: Sudheesh Katkam <sk...@maprtech.com>
Date: 2015-07-14T21:54:16Z
DRILL-2304: Part 2: Manage options with lowercase names
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2304: Case sensitivity - system and sess...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/90#issuecomment-123918173
Addressed review comments mentioned on 313c8e3 f33654c
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2304: Case sensitivity - system and sess...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/90#issuecomment-137505054
@sudheeshkatkam I reviewed this change while I was looking at 3497 in #98. Other than the few small comments over there this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2304: Case sensitivity - system and sess...
Posted by jaltekruse <gi...@git.apache.org>.
Github user jaltekruse commented on the pull request:
https://github.com/apache/drill/pull/90#issuecomment-137777717
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2304: Case sensitivity - system and sess...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/90
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request: DRILL-2304: Case sensitivity - system and sess...
Posted by sudheeshkatkam <gi...@git.apache.org>.
Github user sudheeshkatkam commented on the pull request:
https://github.com/apache/drill/pull/90#issuecomment-137604942
Passes all unit and regression tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---