[jira] [Resolved] (SLING-10997) SlingHttpServletRequestMixin should not implement @ProviderType interface SlingHttpServletRequest

["Stefan Seifert (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-10997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stefan Seifert resolved SLING-10997.
------------------------------------
    Resolution: Fixed

https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/commit/3571d80cbf58fbee01c7c617cf7cc768c981f4a3

> SlingHttpServletRequestMixin should not implement @ProviderType interface SlingHttpServletRequest
> -------------------------------------------------------------------------------------------------
>
>                 Key: SLING-10997
>                 URL: https://issues.apache.org/jira/browse/SLING-10997
>             Project: Sling
>          Issue Type: Bug
>          Components: Sling Models
>    Affects Versions: Models Jackson Exporter 1.1.0
>            Reporter: Stefan Seifert
>            Assignee: Stefan Seifert
>            Priority: Minor
>             Fix For: Models Jackson Exporter 1.1.2
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> the class [org.apache.sling.models.jacksonexporter.impl.SlingHttpServletRequestMixin|https://github.com/apache/sling-org-apache-sling-models-jacksonexporter/blob/1918f563f0c7a3f345af9c1e43ef56b87d4ee345/src/main/java/org/apache/sling/models/jacksonexporter/impl/SlingHttpServletRequestMixin.java] currently actually implements the interface SlingHttpServletRequest  which is marked as @ProviderType.
> the mixin class (and it's siblings for HttpServletRequest and ServletRequest) are only there to instructs the Jackson ObjectMapper what properties should be included in JSON view. without then, the auto-detection may lead to unexpected results, e.g. StackOverflow errors.
> they should refactored in a way without actually implementing those interfaces.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)